linux-kernel - Re: [PATCH v3] virtio-mmio: fix memory leak of vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQIf9uwjnk7DQUf3@shikoro>
Date:   Wed, 13 Sep 2023 22:47:50 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Maximilian Heyne <mheyne@...zon.de>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        virtualization@...ts.linux-foundation.org, stable@...r.kernel.org,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] virtio-mmio: fix memory leak of vm_dev

On Mon, Sep 11, 2023 at 09:03:29AM +0000, Maximilian Heyne wrote:
> With the recent removal of vm_dev from devres its memory is only freed
> via the callback virtio_mmio_release_dev. However, this only takes
> effect after device_add is called by register_virtio_device. Until then
> it's an unmanaged resource and must be explicitly freed on error exit.
> 
> This bug was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 55c91fedd03d ("virtio-mmio: don't break lifecycle of vm_dev")
> Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
> Tested-by: Catalin Marinas <catalin.marinas@....com>
> Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>

Sorry for overlooking this in 55c91fedd03d and thanks for fixing it!

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)