linux-kernel - Re: [PATCH] lsm: constify 'file' parameter in security_bprm_creds_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4a94978e8cc264e51af6ed6c798407a3.paul@paul-moore.com>
Date:   Wed, 13 Sep 2023 18:09:33 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Serge Hallyn <serge@...lyn.com>,
        James Morris <jmorris@...ei.org>,
        linux-security-module@...r.kernel.org, ztarkhani@...rosoft.com,
        alison.schofield@...el.com
Subject: Re: [PATCH] lsm: constify 'file' parameter in  security_bprm_creds_from_file()

On Aug 23, 2023 Khadija Kamran <kamrankhadijadj@...il.com> wrote:
> 
> The 'bprm_creds_from_file' hook has implementation registered in
> commoncap. Looking at the function implementation we observe that the
> 'file' parameter is not changing.
> 
> Mark the 'file' parameter of LSM hook security_bprm_creds_from_file() as
> 'const' since it will not be changing in the LSM hook.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>  include/linux/fs.h            | 2 +-
>  include/linux/lsm_hook_defs.h | 2 +-
>  include/linux/security.h      | 6 +++---
>  security/commoncap.c          | 4 ++--
>  security/security.c           | 2 +-
>  5 files changed, 8 insertions(+), 8 deletions(-)

Merged into lsm/next, thanks!

--
paul-moore.com