linux-kernel - Re: [PATCH 2/2] checkpatch: Add a couple new alloc functions to alloc with multiplies check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7502c1de6c25668699db7ca557f4cd61f2f1eab6.camel@perches.com>
Date:   Wed, 13 Sep 2023 16:00:32 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Gustavo Silva <gustavoars@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: Add a couple new alloc functions to
 alloc with multiplies check

On Wed, 2023-09-13 at 16:41 -0600, Gustavo A. R. Silva wrote:
> 
> On 9/13/23 16:34, Joe Perches wrote:
> > On Wed, 2023-09-13 at 16:32 -0600, Gustavo A. R. Silva wrote:
> > > 
> > > On 9/13/23 16:25, Joe Perches wrote:
> > > > On Wed, 2023-09-13 at 16:14 -0600, Gustavo A. R. Silva wrote:
> > > > > 
> > > > > On 9/13/23 14:37, Joe Perches wrote:
> > > > > > vmalloc() and vzalloc() functions have now 2-factor multiplication
> > > > > > argument forms vmalloc_array() and vcalloc(), correspondingly.
> > > > > > 
> > > > > > Add alloc-with-multiplies checks for these new functions.
> > > > > > 
> > > > > > Simplify the original codes repeated else to use a hash.
> > > > > > 
> > > > > > Link: https://github.com/KSPP/linux/issues/342
> > > > > > 
> > > > > > Original-patch-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > > > > 
> > > > > Why don't you wait for a response or a v2 from the original
> > > > > submitter?
> > > > 
> > > > Because there really is no need to wait.
> > > 
> > > By the way, did you test it?
> > 
> > Yes, against arch/s390/include/asm/idals.h
> 
> I don't see any instances of vmalloc() or vzalloc() in that file.

<snort>  Cute.

Missing a ? in the original search '\s*,?'
or just its removal...

Likely the removal would be better.

thanks, cheers, Joe