linux-kernel - Re: [PATCH -next] tee: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2023 10:39:28 +0200
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Sumit Garg <sumit.garg@...aro.org>
Cc:     Yue Haibing <yuehaibing@...wei.com>, etienne.carriere@...aro.org,
        op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] tee: Remove unused declarations

On Thu, Aug 17, 2023 at 12:11 PM Sumit Garg <sumit.garg@...aro.org> wrote:
>
> On Thu, 10 Aug 2023 at 20:19, Yue Haibing <yuehaibing@...wei.com> wrote:
> >
> > Commit 4fb0a5eb364d ("tee: add OP-TEE driver") declared but never implemented
> > optee_supp_read()/optee_supp_write().
> > Commit 967c9cca2cc5 ("tee: generic TEE subsystem") never implemented tee_shm_init().
> >
> > Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> > ---
> >  drivers/tee/optee/optee_private.h | 2 --
> >  drivers/tee/tee_private.h         | 2 --
> >  2 files changed, 4 deletions(-)
> >
>
> Reviewed-by: Sumit Garg <sumit.garg@...aro.org>

I'm picking up this.

Thanks,
Jens

>
> -Sumit
>
> > diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h
> > index 72685ee0d53f..6bb5cae09688 100644
> > --- a/drivers/tee/optee/optee_private.h
> > +++ b/drivers/tee/optee/optee_private.h
> > @@ -238,8 +238,6 @@ int optee_notif_send(struct optee *optee, u_int key);
> >  u32 optee_supp_thrd_req(struct tee_context *ctx, u32 func, size_t num_params,
> >                         struct tee_param *param);
> >
> > -int optee_supp_read(struct tee_context *ctx, void __user *buf, size_t len);
> > -int optee_supp_write(struct tee_context *ctx, void __user *buf, size_t len);
> >  void optee_supp_init(struct optee_supp *supp);
> >  void optee_supp_uninit(struct optee_supp *supp);
> >  void optee_supp_release(struct optee_supp *supp);
> > diff --git a/drivers/tee/tee_private.h b/drivers/tee/tee_private.h
> > index 409cadcc1cff..754e11dcb240 100644
> > --- a/drivers/tee/tee_private.h
> > +++ b/drivers/tee/tee_private.h
> > @@ -47,8 +47,6 @@ struct tee_device {
> >         struct tee_shm_pool *pool;
> >  };
> >
> > -int tee_shm_init(void);
> > -
> >  int tee_shm_get_fd(struct tee_shm *shm);
> >
> >  bool tee_device_get(struct tee_device *teedev);
> > --
> > 2.34.1
> >