[<prev] [next>] [day] [month] [year] [list]
Message-ID: <501c0133.60683.18a8dcfa512.Coremail.sunying@isrc.iscas.ac.cn>
Date: Wed, 13 Sep 2023 17:11:50 +0800 (GMT+08:00)
From: sunying@...c.iscas.ac.cn
To: airlied@...il.com, daniel@...ll.ch
Cc: dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, pengpeng@...as.ac.cn,
renyanjie01@...il.com
Subject: drivers/gpu/drm/nouveau/nvkm/subdev/i2c/bit.c and bus.c with a
series of the non-existing config "NOUVEAU_I2C_INTERNAL"
In the source files drivers/gpu/drm/nouveau/nvkm/subdev/i2c/bit.c:26 and
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/bus.c:214 refer to
configuration options "CONFIG_NOUVEAU_I2C_INTERNAL" and
"CONFIG_NOUVEAU_I2C_INTERNAL_DEFAULT" for conditional compilation,
but these configuration options are not defined in any kconfig files,
which means the "#ifdef CONFIG_NOUVEAU_I2C_INTERNAL_xxx" condition contains dead code.
Do these configuration options need to be retained and added later?
Or can we simply drop the dead code?
Best regards,
Yanjie Ren
Ying Sun
Powered by blists - more mailing lists