linux-kernel - Re: [PATCH] btrfs: Remove some unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4399a6f7-b1b5-4b5d-a36a-7e1719db6b57@wdc.com>
Date:   Wed, 13 Sep 2023 10:05:50 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "clm@...com" <clm@...com>
CC:     "josef@...icpanda.com" <josef@...icpanda.com>,
        "dsterba@...e.com" <dsterba@...e.com>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] btrfs: Remove some unused functions

On 13.09.23 11:44, Jiapeng Chong wrote:
> These functions are defined in the qgroup.c file, but not called
> elsewhere, so delete these unused functions.

anywhere

> fs/btrfs/qgroup.c:149:19: warning: unused function 'qgroup_to_aux'
> fs/btrfs/qgroup.c:154:36: warning: unused function 'unode_aux_to_qgroup'.

The last user of them is gone since:

d852a91a696a ("btrfs: qgroup: use qgroup_iterator_nested to in 
qgroup_update_refcnt()")


Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>