linux-kernel - Re: [PATCH] tracing/user_events: fix long size check in the ABI selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1531a48-b59d-d5ff-130b-5cc6a571a9d1@intel.com>
Date:   Wed, 13 Sep 2023 12:07:02 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Shuah Khan <shuah@...nel.org>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>
CC:     Beau Belgrave <beaub@...ux.microsoft.com>,
        Ira Weiny <ira.weiny@...el.com>,
        <linux-kselftest@...r.kernel.org>, <stable@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/user_events: fix long size check in the ABI
 selftest

From: Alexander Lobakin <aleksander.lobakin@...el.com>
Date: Mon, 11 Sep 2023 18:09:35 +0200

> The current check for 64-bit architecture is double-bugged.
> First of all, %BITS_PER_LONG is not available in the userspace,
> the underscored version from <asm/bitsperlong.h> must be used.
> The following check:
> 
>  #if BITS_PER_LONG == 0
>  #error
>  #endif
> 
> triggers the error in this source file -- the macro is undefined and
> thus is implicitly evaluated to 0.
> Next, %BITS_PER_LONG means "bits", not "bytes". In the Linux kernel,
> it can be 32 or 64, never 8. Given that the tests guarded by that check
> are meant to be run on a 64-bit system, the correct value would be 64.
> 
> Prefix the macro name and fix the value it's compared to.
> 
> Fixes: 60b1af8de8c1 ("tracing/user_events: Add ABI self-test")
> Cc: stable@...r.kernel.org # 6.4+
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Patchwork says "Accepted", but I don't see it anywhere on korg O_o

[...]

Thanks,
Olek