linux-kernel - Re: [PATCH v2 02/14] arm64: dts: qcom: msm8996: Drop RPM bus clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <92bc6544-b652-41f5-8819-016c4f93e827@protonmail.com>
Date:   Wed, 13 Sep 2023 10:17:39 +0000
From:   Yassine Oudjana <y.oudjana@...tonmail.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Joerg Roedel <joro@...tes.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Alexey Minnekhanov <alexeymin@...tmarketos.org>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 02/14] arm64: dts: qcom: msm8996: Drop RPM bus clocks

On 12/09/2023 4:31 pm, Konrad Dybcio wrote:
> These clocks are now handled from within the icc framework and are
> no longer registered from within the CCF. Remove them.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/msm8996.dtsi | 27 ++++-----------------------
>   1 file changed, 4 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index c8e0986425ab..acef67ab0581 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -798,9 +798,6 @@ bimc: interconnect@...000 {
>   			compatible = "qcom,msm8996-bimc";
>   			reg = <0x00408000 0x5a000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a";
> -			clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> -				 <&rpmcc RPM_SMD_BIMC_A_CLK>;
>   		};
>   
>   		tsens0: thermal-sensor@...000 {
> @@ -851,18 +848,12 @@ cnoc: interconnect@...000 {
>   			compatible = "qcom,msm8996-cnoc";
>   			reg = <0x00500000 0x1000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a";
> -			clocks = <&rpmcc RPM_SMD_CNOC_CLK>,
> -				 <&rpmcc RPM_SMD_CNOC_A_CLK>;
>   		};
>   
>   		snoc: interconnect@...000 {
>   			compatible = "qcom,msm8996-snoc";
>   			reg = <0x00524000 0x1c000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a";
> -			clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> -				 <&rpmcc RPM_SMD_SNOC_A_CLK>;
>   		};
>   
>   		a0noc: interconnect@...000 {
> @@ -882,19 +873,14 @@ a1noc: interconnect@...000 {
>   			compatible = "qcom,msm8996-a1noc";
>   			reg = <0x00562000 0x5000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a";
> -			clocks = <&rpmcc RPM_SMD_AGGR1_NOC_CLK>,
> -				 <&rpmcc RPM_SMD_AGGR1_NOC_A_CLK>;
>   		};
>   
>   		a2noc: interconnect@...000 {
>   			compatible = "qcom,msm8996-a2noc";
>   			reg = <0x00583000 0x7000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a", "aggre2_ufs_axi", "ufs_axi";
> -			clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
> -				 <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>,
> -				 <&gcc GCC_AGGRE2_UFS_AXI_CLK>,
> +			clock-names = "aggre2_ufs_axi", "ufs_axi";
> +			clocks = <&gcc GCC_AGGRE2_UFS_AXI_CLK>,
>   				 <&gcc GCC_UFS_AXI_CLK>;
>   		};
>   
> @@ -902,19 +888,14 @@ mnoc: interconnect@...000 {
>   			compatible = "qcom,msm8996-mnoc";
>   			reg = <0x005a4000 0x1c000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a", "iface";
> -			clocks = <&rpmcc RPM_SMD_MMAXI_CLK>,
> -				 <&rpmcc RPM_SMD_MMAXI_A_CLK>,
> -				 <&mmcc AHB_CLK_SRC>;
> +			clock-names = "iface";
> +			clocks = <&mmcc AHB_CLK_SRC>;
>   		};
>   
>   		pnoc: interconnect@...000 {
>   			compatible = "qcom,msm8996-pnoc";
>   			reg = <0x005c0000 0x3000>;
>   			#interconnect-cells = <1>;
> -			clock-names = "bus", "bus_a";
> -			clocks = <&rpmcc RPM_SMD_PCNOC_CLK>,
> -				 <&rpmcc RPM_SMD_PCNOC_A_CLK>;
>   		};
>   
>   		tcsr_mutex: hwlock@...000 {

Tested-by: Yassine Oudjana <y.oudjana@...tonmail.com>