linux-kernel - Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48972ab0-e4ed-11b2-31fb-ad93695a4db1@ideasonboard.com>
Date:   Wed, 13 Sep 2023 15:11:08 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     airlied@...il.com, daniel@...ll.ch, u.kleine-koenig@...gutronix.de,
        arnd@...db.de, laurent.pinchart@...asonboard.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
        Sebastian Reichel <sre@...nel.org>
Subject: Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

On 13/09/2023 09:59, Andreas Kemnade wrote:
> Some 3.0 source has it set behind a if (omap4).
> Maybe it is helpful maybe not, at least in the omap4460
> trm these bits are marked as reserved.
> But maybe some dsi video mode panel starts magically working.

Sorry, what does this mean? That this fixes something, or you are just 
guessing?

I'm somewhat sure that the upstream driver used to work on omap4 sdp, 
which has two DSI panels. But I can't even remember what omap4 version 
it had.

  Tomi

> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>   drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 60189a23506a1..e2f576cd9f63c 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -4505,7 +4505,7 @@ static const struct dss_pll_hw dss_omap4_dsi_pll_hw = {
>   	.has_stopmode = true,
>   	.has_freqsel = false,
>   	.has_selfreqdco = false,
> -	.has_refsel = false,
> +	.has_refsel = true,
>   };
>   
>   static const struct dss_pll_hw dss_omap5_dsi_pll_hw = {