linux-kernel - Re: [PATCH v5 11/14] media: platform: mtk-mdp3: add mt8195 platform configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8f12e96e49f471f287db82cee51b3104e2bc0de.camel@mediatek.com>
Date:   Wed, 13 Sep 2023 02:08:35 +0000
From:   Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "airlied@...il.com" <airlied@...il.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 11/14] media: platform: mtk-mdp3: add mt8195 platform
 configuration

On Tue, 2023-09-12 at 10:21 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 12/09/2023 09:58, Moudy Ho wrote:
> > Add MT8195 MDP3 basic configuration in file "mdp_cfg_data.c"
> > and corresponding driver data.
> > 
> > Signed-off-by: Moudy Ho <moudy.ho@...iatek.com>
> 
> ...
> 
> >  {}
> >  };
> > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> > index 06b7d2b0b814..8b69bd8b91c6 100644
> > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> > @@ -21,6 +21,9 @@ static const struct of_device_id mdp_of_ids[] = {
> >  { .compatible = "mediatek,mt8183-mdp3-rdma",
> >    .data = &mt8183_mdp_driver_data,
> >  },
> > +{ .compatible = "mediatek,mt8195-mdp3-rdma",
> 
> You keep adding undocumented compatibles. Your way of organizing
> patches
> does not have any sense. DTS should not be mixed with media subsystem
> -
> they *CANNOT* go via one subsystem. In the same time bindings are
> always
> going via subsystem, so why are they missing here?
> 
> This does not make any sense and such mess at v5 is confusing.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,


Apologize for the confusion caused by the improper separation of
patches.
This occurred because I misunderstood the new warning message
"DT_SPLIT_BINDING_PATCH: DT binding docs and includes shoulde be a
separate patch" that I received after running 'checkpatch.pl'.
I will rectify this mishandling as soon as possible.

Sincerely,
Moudy