linux-kernel - Re: [PATCH 2/2] pm80xx: Avoid leaking tags when processing OPC_INB_SET_CONTROLLER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2023 15:42:32 +0200
From:   Jinpu Wang <jinpu.wang@...os.com>
To:     Michal Grzedzicki <mge@...a.com>
Cc:     jinpu.wang@...ud.ionos.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pm80xx: Avoid leaking tags when processing
 OPC_INB_SET_CONTROLLER_CONFIG command

On Mon, Sep 11, 2023 at 7:03 PM Michal Grzedzicki <mge@...a.com> wrote:
>
> Tags allocated for OPC_INB_SET_CONTROLLER_CONFIG command need to be freed
> when we receive the response.
>
> Signed-off-by: Michal Grzedzicki <mge@...a.com>
can you please add the fixes tag, so stable can pick it accordingly?
Acked-by: Jack Wang <jinpu.wang@...os.com>
> ---
>  drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c
> index 1b2c40b1381c..3afd9443c425 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -3671,10 +3671,12 @@ static int mpi_set_controller_config_resp(struct pm8001_hba_info *pm8001_ha,
>                         (struct set_ctrl_cfg_resp *)(piomb + 4);
>         u32 status = le32_to_cpu(pPayload->status);
>         u32 err_qlfr_pgcd = le32_to_cpu(pPayload->err_qlfr_pgcd);
> +       u32 tag = le32_to_cpu(pPayload->tag);
>
>         pm8001_dbg(pm8001_ha, MSG,
>                    "SET CONTROLLER RESP: status 0x%x qlfr_pgcd 0x%x\n",
>                    status, err_qlfr_pgcd);
> +       pm8001_tag_free(pm8001_ha, tag);
>
>         return 0;
>  }
> --
> 2.34.1
>