linux-kernel - Re: drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse: incorrect type in initializer (different base types)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230913144340.l2vg6wtq56lnzejn@mercury.elektranox.org>
Date:   Wed, 13 Sep 2023 16:43:40 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Bjorn Andersson <andersson@...nel.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse:
 incorrect type in initializer (different base types)

Hi Bjorn,

On Mon, Aug 28, 2023 at 06:19:22AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   85eb043618bb17124050197d71c453d4a1f556e5
> commit: 29e8142b5623b5949587bcc4f591c4e6595c4aca power: supply: Introduce Qualcomm PMIC GLINK power supply
> date:   7 months ago
> config: i386-randconfig-061-20230828 (https://download.01.org/0day-ci/archive/20230828/202308280602.nE6xa80J-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20230828/202308280602.nE6xa80J-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308280602.nE6xa80J-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/power/supply/qcom_battmgr.c:357:31: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned int [usertype] battery_id @@     got restricted __le32 [usertype] @@
>    drivers/power/supply/qcom_battmgr.c:357:31: sparse:     expected unsigned int [usertype] battery_id
>    drivers/power/supply/qcom_battmgr.c:357:31: sparse:     got restricted __le32 [usertype]
>    drivers/power/supply/qcom_battmgr.c:369:31: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned int [usertype] battery_id @@     got restricted __le32 [usertype] @@
>    drivers/power/supply/qcom_battmgr.c:369:31: sparse:     expected unsigned int [usertype] battery_id
>    drivers/power/supply/qcom_battmgr.c:369:31: sparse:     got restricted __le32 [usertype]
> >> drivers/power/supply/qcom_battmgr.c:1286:30: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __le32 [usertype] owner @@     got int @@
>    drivers/power/supply/qcom_battmgr.c:1286:30: sparse:     expected restricted __le32 [usertype] owner
>    drivers/power/supply/qcom_battmgr.c:1286:30: sparse:     got int
> >> drivers/power/supply/qcom_battmgr.c:1287:29: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __le32 [usertype] type @@     got int @@
>    drivers/power/supply/qcom_battmgr.c:1287:29: sparse:     expected restricted __le32 [usertype] type
>    drivers/power/supply/qcom_battmgr.c:1287:29: sparse:     got int
> >> drivers/power/supply/qcom_battmgr.c:1288:31: sparse: sparse: incorrect type in initializer (different base types) @@     expected restricted __le32 [usertype] opcode @@     got int @@
>    drivers/power/supply/qcom_battmgr.c:1288:31: sparse:     expected restricted __le32 [usertype] opcode
>    drivers/power/supply/qcom_battmgr.c:1288:31: sparse:     got int
> 
> vim +357 drivers/power/supply/qcom_battmgr.c
> 
>    350	
>    351	static int qcom_battmgr_update_status(struct qcom_battmgr *battmgr)
>    352	{
>    353		struct qcom_battmgr_update_request request = {
>    354			.hdr.owner = cpu_to_le32(PMIC_GLINK_OWNER_BATTMGR),
>    355			.hdr.type = cpu_to_le32(PMIC_GLINK_REQ_RESP),
>    356			.hdr.opcode = cpu_to_le32(BATTMGR_BAT_STATUS),
>  > 357			.battery_id = cpu_to_le32(0),
>    358		};
>    359	
>    360		return qcom_battmgr_request(battmgr, &request, sizeof(request));
>    361	}
>    362	

It looks like  battery_id should be __le32 in 'struct
qcom_battmgr_update_request', care to send a patch for that?

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)