linux-kernel - Re: [PATCH v3 1/3] powerpc/config: Cleanup pmac32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A81E00EBD697C30F+9c7a7721-e949-4ca6-a6b3-8eeb181718f2@tinylab.org>
Date:   Thu, 14 Sep 2023 22:37:38 +0800
From:   Yuan Tan <tanyuan@...ylab.org>
To:     Michael Ellerman <mpe@...erman.id.au>, christophe.leroy@...roup.eu
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        falcon@...ylab.org, w@....eu, linux@...ssschuh.net,
        Philippe Mathieu-Daudé <philmd@...aro.org>
Subject: Re: [PATCH v3 1/3] powerpc/config: Cleanup pmac32_defconfig

Hi Michael

On 9/14/2023 9:10 PM, Michael Ellerman wrote:
> Yuan Tan <tanyuan@...ylab.org> writes:
>> Use 'make savedefconfig' to cleanup pmac32_defconfig, based on Linux
>> 7.6-rc1
> Thanks but I don't like doing these updates in a single commit like
> this, it's easy to accidentally lose a symbol.
Yeah I have the same concerns too.
>
> I prefer an explanation for what's changing for each symbol. See
> 1ce7fda142af ("powerpc/configs/64s: Drop IPV6 which is default y") and
> the commits leading up to it, to see what I mean.
>
> But I suspect you probably don't want to go to all that effort, which is
> fine :)

I am not familiar with other options, so I'd better not do that. :)

By the way, just to be cautious, since the defconfig can only be updated 
by 'savedefconfig'[1], how can we write an explanation for a single 
change in an option?

I mean, when I change one option, the value of the other undetermined 
option will be set just like in patch 1.

[1]: 
https://lore.kernel.org/all/54da2376-dc65-0a96-55df-7a5acfbb9bff@csgroup.eu/
>
> So I won't take patch 1, but patch 2 and 3 look fine. No need to resend,
> I'll deal with any merge fixup needed.
>
> cheers
Thank you :)