linux-kernel - Re: [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <580f3934ab1171e27d785db7362c342d.sboyd@kernel.org>
Date:   Thu, 14 Sep 2023 09:30:15 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jie Luo <quic_luoj@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, catalin.marinas@....com, conor+dt@...nel.org,
        konrad.dybcio@...aro.org, krzysztof.kozlowski+dt@...aro.org,
        mturquette@...libre.com, p.zabel@...gutronix.de,
        robh+dt@...nel.org, will@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_srichara@...cinc.com
Subject: Re: [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084

Quoting Jie Luo (2023-09-12 20:27:25)
> 
> 
> On 9/13/2023 1:18 AM, Stephen Boyd wrote:
> > Quoting Jie Luo (2023-09-12 05:07:02)
> >>
> >> and freq_tbl are necessary to this clock.
> > 
> > I still don't see why the freq_tbl is necessary.
> 
> Hi Stephen,
> For clk_rcg2_ops, freq_tbl is used to find the closest rate to decided 
> the parent clock, the configuration of clock source and clock divider 
> are saved in the freq_tbl to configure the RCG hardware register, the 
> mapping of parent clock and hardware register value is decided by the 
> freq_tbl for the RCG clock.

The divider is always 1. The frequency is the frequency of the parent.
The two pieces of information are already known without the frequency
table. Why is it needed?