linux-kernel - Re: [PATCH] vfio/pds: Use proper PF device access helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08009a16-f6b6-f644-406e-ea3dd0a858f1@amd.com>
Date:   Thu, 14 Sep 2023 10:31:53 -0700
From:   Brett Creeley <bcreeley@....com>
To:     oushixiong <oushixiong@...inos.cn>, Jason Gunthorpe <jgg@...pe.ca>
Cc:     Yishai Hadas <yishaih@...dia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Brett Creeley <brett.creeley@....com>,
        Alex Williamson <alex.williamson@...hat.com>,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio/pds: Use proper PF device access helper

On 9/13/2023 7:13 PM, oushixiong wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> From: Shixiong Ou <oushixiong@...inos.cn>
> 
> The pci_physfn() helper exists to support cases where the physfn
> field may not be compiled into the pci_dev structure. We've
> declared this driver dependent on PCI_IOV to avoid this problem,
> but regardless we should follow the precedent not to access this
> field directly.
> 
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
> ---
> 
> This patch changes the subject line and commit log, and the previous
> patch's links is:
>          https://patchwork.kernel.org/project/kvm/patch/20230911080828.635184-1-oushixiong@kylinos.cn/
> 
>   drivers/vfio/pci/pds/vfio_dev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c
> index b46174f5eb09..649b18ee394b 100644
> --- a/drivers/vfio/pci/pds/vfio_dev.c
> +++ b/drivers/vfio/pci/pds/vfio_dev.c
> @@ -162,7 +162,7 @@ static int pds_vfio_init_device(struct vfio_device *vdev)
>          pci_id = PCI_DEVID(pdev->bus->number, pdev->devfn);
>          dev_dbg(&pdev->dev,
>                  "%s: PF %#04x VF %#04x vf_id %d domain %d pds_vfio %p\n",
> -               __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> +               __func__, pci_dev_id(pci_physfn(pdev)), pci_id, vf_id,
>                  pci_domain_nr(pdev->bus), pds_vfio);
> 
>          return 0;
> --
> 2.25.1
> 

LGTM! Thanks again.

Reviewed-by: Brett Creeley <brett.creeley@....com>