linux-kernel - Re: [PATCH] kbuild: avoid long argument lists in make modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASTc80bZY1Kvk4rwRk=jL0uCaOfc0ggmWv5O994WD=rsg@mail.gmail.com>
Date:   Fri, 15 Sep 2023 02:37:17 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: avoid long argument lists in make modules_install

On Mon, Sep 11, 2023 at 5:01 PM Michal Kubecek <mkubecek@...e.cz> wrote:
>
> Running "make modules_install" may fail with
>
>   make[2]: execvp: /bin/sh: Argument list too long
>
> if many modules are built and INSTALL_MOD_PATH is long. This is because
> scripts/Makefile.modinst creates all directories with one mkdir command.
> Use $(foreach ...) instead to prevent an excessive argument list.
>
> Fixes: 2dfec887c0fd ("kbuild: reduce the number of mkdir calls during modules_install")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> ---

Applied to linux-kbuild/fixes.
Thanks.



>  scripts/Makefile.modinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index c59cc57286ba..346f5ec50682 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -113,7 +113,7 @@ quiet_cmd_sign :=
>  endif
>
>  # Create necessary directories
> -$(shell mkdir -p $(sort $(dir $(install-y))))
> +$(foreach dir, $(sort $(dir $(install-y))), $(shell mkdir -p $(dir)))
>
>  $(dst)/%.ko: $(extmod_prefix)%.ko FORCE
>         $(call cmd,install)
> --
> 2.42.0
>


-- 
Best Regards
Masahiro Yamada