[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1694715351-58279-1-git-send-email-lizhi.hou@amd.com>
Date: Thu, 14 Sep 2023 11:15:51 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: <linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <herve.codina@...tlin.com>
CC: Lizhi Hou <lizhi.hou@....com>, <bhelgaas@...gle.com>,
<robh@...nel.org>
Subject: [PATCH] PCI: of: Fix memory leak when of_changeset_create_node() failed
Destroy and free cset when failure happens.
Fixes: 407d1a51921e ("PCI: Create device tree node for bridge")
Reported-by: Herve Codina <herve.codina@...tlin.com>
Closes: https://lore.kernel.org/all/20230911171319.495bb837@bootlin.com/
Signed-off-by: Lizhi Hou <lizhi.hou@....com>
---
drivers/pci/of.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 2af64bcb7da3..67bbfa2fca59 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -663,7 +663,6 @@ void of_pci_make_dev_node(struct pci_dev *pdev)
np = of_changeset_create_node(cset, ppnode, name);
if (!np)
goto failed;
- np->data = cset;
ret = of_pci_add_properties(pdev, cset, np);
if (ret)
@@ -673,12 +672,17 @@ void of_pci_make_dev_node(struct pci_dev *pdev)
if (ret)
goto failed;
+ np->data = cset;
pdev->dev.of_node = np;
kfree(name);
return;
failed:
+ if (cset) {
+ of_changeset_destroy(cset);
+ kfree(cset);
+ }
if (np)
of_node_put(np);
kfree(name);
--
2.34.1
Powered by blists - more mailing lists