linux-kernel - Re: [PATCH v3] libnvdimm/of_pmem: Use devm_kstrdup instead of kstrdup and check its return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6503634e78f61_35db1029469@iweiny-mobl.notmuch>
Date:   Thu, 14 Sep 2023 12:47:26 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Dave Jiang <dave.jiang@...el.com>, Chen Ni <nichen@...as.ac.cn>,
        <oohall@...il.com>, <dan.j.williams@...el.com>,
        <vishal.l.verma@...el.com>, <ira.weiny@...el.com>,
        <aneesh.kumar@...ux.ibm.com>
CC:     <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] libnvdimm/of_pmem: Use devm_kstrdup instead of
 kstrdup and check its return value

Dave Jiang wrote:
> 
> 
> On 9/14/23 00:03, Chen Ni wrote:

[snip]

> > diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> > index 1b9f5b8a6167..5765674b36f2 100644
> > --- a/drivers/nvdimm/of_pmem.c
> > +++ b/drivers/nvdimm/of_pmem.c
> > @@ -30,7 +30,13 @@ static int of_pmem_region_probe(struct platform_device *pdev)
> >  	if (!priv)
> >  		return -ENOMEM;
> >  
> > -	priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
> > +	priv->bus_desc.provider_name = devm_kstrdup(&pdev->dev, pdev->name,
> > +							GFP_KERNEL);
> > +	if (!priv->bus_desc.provider_name) {
> > +		kfree(priv);
> 
> I wonder if priv should be allocated with devm_kzalloc() instead to reduce the resource management burden. 

I think it could be but this is the driver and I wonder if leaving the
allocation around until the platform device goes away was undesirable for
some reason?

Ira