linux-kernel - Re: [PATCH 01/17] pmdomain: Prepare to move Kconfig files into the pmdomain subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFoRYn0G0W2g4HhiVE3osmGuZHox=79J8o9bOfUe0Aq_oA@mail.gmail.com>
Date:   Fri, 15 Sep 2023 00:35:13 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/17] pmdomain: Prepare to move Kconfig files into the
 pmdomain subsystem

On Thu, 14 Sept 2023 at 13:59, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Ulf,
>
> On Thu, Sep 14, 2023 at 1:17 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:
> > Rather than having the various Kconfig files for the genpd providers
> > sprinkled across subsystems, let's prepare to move them into the pmdomain
> > subsystem along with the implementations.
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
>
> Thanks for your patch!
>
> > --- a/drivers/Kconfig
> > +++ b/drivers/Kconfig
> > @@ -175,6 +175,8 @@ source "drivers/soundwire/Kconfig"
> >
> >  source "drivers/soc/Kconfig"
> >
> > +source "drivers/genpd/Kconfig"
>
> drivers/pmdomain/Kconfig

Ohh, thanks for spotting this! I certainly failed in my internal re-base. :-(

>
> > +
> >  source "drivers/devfreq/Kconfig"
> >
> >  source "drivers/extcon/Kconfig"
> > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> > new file mode 100644
> > index 000000000000..c32a76b51840
> > --- /dev/null
> > +++ b/drivers/pmdomain/Kconfig
> > @@ -0,0 +1,4 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +menu "Power Domains Support"
>
> PM Domains

Yep, that is better as it has a wider meaning (it can incorporate
clock-domains and performance-domains, for example). Let me change
that, thanks!

I will follow this pattern for each of the submenus too.

>
> > +
> > +endmenu
>
> "b4 am" cannot download the full series at once.
> It looks like you didn't send it as a series, but as individual patches?

I screwed up when sending. Sorry. I will submit a new version!

Thanks for reviewing!

Kind regards
Uffe