linux-kernel - Re: [PATCH] riscv: mm: Update the comment of CONFIG_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTRHbvwyZR_qUNsc3E9X=Y1H7yTcZo3NLgXQ45=jm1jbTg@mail.gmail.com>
Date:   Thu, 14 Sep 2023 12:59:41 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Song Shuai <songshuaishuai@...ylab.org>
Cc:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, ajones@...tanamicro.com,
        alexghiti@...osinc.com, anup@...infault.org, samuel@...lland.org,
        rppt@...nel.org, suagrfillet@...il.com, panqinglin2020@...as.ac.cn,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: mm: Update the comment of CONFIG_PAGE_OFFSET

On Wed, Aug 9, 2023 at 11:11 AM Song Shuai <songshuaishuai@...ylab.org> wrote:
>
> From: Song Shuai <suagrfillet@...il.com>
>
> Since the commit 011f09d12052 set sv57 as default for CONFIG_64BIT,
> the comment of CONFIG_PAGE_OFFSET should be updated too.
>
> Fixes: 011f09d12052 ("riscv: mm: Set sv57 on defaultly")
> Signed-off-by: Song Shuai <suagrfillet@...il.com>
> ---
>  arch/riscv/include/asm/page.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h
> index b55ba20903ec..53c00164c042 100644
> --- a/arch/riscv/include/asm/page.h
> +++ b/arch/riscv/include/asm/page.h
> @@ -33,8 +33,8 @@
>  #define PAGE_OFFSET            _AC(CONFIG_PAGE_OFFSET, UL)
Why not remove CONFIG_PAGE_OFFSET and define PAGE_OFFSET_L2 ?

>  #endif
>  /*
> - * By default, CONFIG_PAGE_OFFSET value corresponds to SV48 address space so
> - * define the PAGE_OFFSET value for SV39.
> + * By default, CONFIG_PAGE_OFFSET value corresponds to SV57 address space so
> + * define the PAGE_OFFSET value for SV48 and SV39.
>   */
>  #define PAGE_OFFSET_L4         _AC(0xffffaf8000000000, UL)
>  #define PAGE_OFFSET_L3         _AC(0xffffffd800000000, UL)
> --
> 2.20.1
>


-- 
Best Regards
 Guo Ren