linux-kernel - Re: [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1jzstfu2z.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 13 Sep 2023 21:00:11 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Rob Herring <robh@...nel.org>, Bjorn Helgaas <helgaas@...nel.org>,
        linux-pci@...r.kernel.org, Brian King <brking@...ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        3chas3@...il.com, dalias@...c.org, glaubitz@...sik.fu-berlin.de,
        ink@...assic.park.msu.ru, kw@...ux.com,
        linux-alpha@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-atm-general@...ts.sourceforge.net, linux-sh@...r.kernel.org,
        lpieralisi@...nel.org, mattst88@...il.com, netdev@...r.kernel.org,
        richard.henderson@...aro.org, toan@...amperecomputing.com,
        ysato@...rs.sourceforge.jp
Subject: Re: [PATCH v3 6/6] scsi: ipr: Do PCI error checks on own line


Ilpo,

> Instead of if conditions with line splits, use the usual error handling
> pattern with a separate variable to improve readability.
>
> No functional changes intended.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering