linux-kernel - Re: [PATCH 1/2] bcachefs: Fix a potential in the error handling path of use-after-free inbch2_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d1d83df-c1d1-22b0-72a0-291a68d0c328@wanadoo.fr>
Date:   Thu, 14 Sep 2023 07:28:39 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Kent Overstreet <kent.overstreet@...ux.dev>
Cc:     Brian Foster <bfoster@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcachefs@...r.kernel.org
Subject: Re: [PATCH 1/2] bcachefs: Fix a potential in the error handling path
 of use-after-free inbch2_dev_add()


Le 14/09/2023 à 01:01, Kent Overstreet a écrit :
> On Wed, Sep 13, 2023 at 06:44:08PM +0200, Christophe JAILLET wrote:
>> If __bch2_dev_attach_bdev() fails, bch2_dev_free() is called twice.
>> Once here and another time in the error handling path.
>>
>> This leads to several use-after-free.
>>
>> Remove the redundant call and only rely on the error handling path.
> Thanks, both applied



If not too late, it is more a double-free than a use-after-free.

And I messed up the ordering of the words in the subject.

Sorry about that.

CJ