linux-kernel - RE: [PATCH V2] pci: introduce static_nr to indicate domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DU0PR04MB94174CD722E027BB537ED66988F7A@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Thu, 14 Sep 2023 06:10:25 +0000
From:   Peng Fan <peng.fan@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        Jan Kiszka <jan.kiszka@...mens.com>
CC:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "pali@...nel.org" <pali@...nel.org>,
        "ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2] pci: introduce static_nr to indicate domain_nr from
 which IDA

Sorry for not being clear when Ccing you.

> Subject: Re: [PATCH V2] pci: introduce static_nr to indicate domain_nr from

The Major question is Bjorn says "
It looks like you're using a notifier call chain to remove the devices 
when the of_changeset is removed.  I think that's the wrong approach.
The only in-tree user of of_changeset_revert() is i2c-demux-pinctrl.c, 
which uses the ordering I suggested:
"
And 
"
The current ordering is this, where A happens before B:
  A overlay is removed
  B pci_host_common_remove
      pci_bus_release_domain_nr
        of_pci_bus_release_domain_nr
          of_get_pci_domain_nr      # fails because overlay is gone
          ida_free(&pci_domain_nr_dynamic_ida)

But if the host bridge were removed first, the ordering would be as follows,
and the problem would not occur:

  B pci_host_common_remove
      pci_bus_release_domain_nr
        of_pci_bus_release_domain_nr
          of_get_pci_domain_nr      # succeeds in this order
          ida_free(&pci_domain_nr_static_ida)
  A overlay is removed
"

I wonder whether it is a must to call pci_host_common_remove, then
remove overlay, or overlay remove automatically trigger
pci_host_common_remove is correct?

Thanks,
Peng.

> 
> This does not work like this. Ccing me on some huge bunch of quoted text
> without any comment is pointless. Do you expect me to read everything just
> because you want? I clearly have not enough of work to do, right?
> 
> Ask specific question if you need anything from other people. Direct and
> specific question, but not "what do you think?" (the same as this quote). I am
> going just to ignore this email.
> 
> Best regards,
> Krzysztof