linux-kernel - Re: [PATCH v3 3/3] perf pmu: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5976613f-8c7b-81a8-3200-9f0603f90743@oracle.com>
Date:   Thu, 14 Sep 2023 07:41:45 +0100
From:   John Garry <john.g.garry@...cle.com>
To:     James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, irogers@...gle.com,
        acme@...nel.org
Cc:     Will Deacon <will@...nel.org>, Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Haixin Yu <yuhaixin.yhx@...ux.alibaba.com>,
        Jing Zhang <renyu.zj@...ux.alibaba.com>,
        Eduard Zingerman <eddyz87@...il.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] perf pmu: Remove unused function

On 13/09/2023 16:33, James Clark wrote:
> pmu_events_table__find() is no longer used so remove it and its Arm
> specific version.
> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>
> Signed-off-by: James Clark <james.clark@....com>
> ---

You really should put the name of the function in the subject. Apart 
from that:

Reviewed-by: John Garry <john.g.garry@...cle.com>

>   tools/perf/arch/arm64/util/pmu.c | 10 ----------
>   tools/perf/util/pmu.c            |  5 -----
>   tools/perf/util/pmu.h            |  1 -
>   3 files changed, 16 deletions(-)
> 
> diff --git a/tools/perf/arch/arm64/util/pmu.c b/tools/perf/arch/arm64/util/pmu.c
> index 3099f5f448ba..2a4eab2d160e 100644
> --- a/tools/perf/arch/arm64/util/pmu.c
> +++ b/tools/perf/arch/arm64/util/pmu.c
> @@ -24,16 +24,6 @@ const struct pmu_metrics_table *pmu_metrics_table__find(void)
>   	return NULL;
>   }
>   
> -const struct pmu_events_table *pmu_events_table__find(void)
> -{
> -	struct perf_pmu *pmu = perf_pmus__find_core_pmu();
> -
> -	if (pmu)
> -		return perf_pmu__find_events_table(pmu);
> -
> -	return NULL;
> -}
> -
>   double perf_pmu__cpu_slots_per_cycle(void)
>   {
>   	char path[PATH_MAX];
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index f50a5636633f..0d81c059c91c 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -776,11 +776,6 @@ char *perf_pmu__getcpuid(struct perf_pmu *pmu)
>   	return cpuid;
>   }
>   
> -__weak const struct pmu_events_table *pmu_events_table__find(void)
> -{
> -	return perf_pmu__find_events_table(NULL);
> -}
> -
>   __weak const struct pmu_metrics_table *pmu_metrics_table__find(void)
>   {
>   	return perf_pmu__find_metrics_table(NULL);
> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> index d7b46085642d..04b317b17d66 100644
> --- a/tools/perf/util/pmu.h
> +++ b/tools/perf/util/pmu.h
> @@ -238,7 +238,6 @@ void pmu_add_cpu_aliases_table(struct perf_pmu *pmu,
>   			       const struct pmu_events_table *table);
>   
>   char *perf_pmu__getcpuid(struct perf_pmu *pmu);
> -const struct pmu_events_table *pmu_events_table__find(void);
>   const struct pmu_metrics_table *pmu_metrics_table__find(void);
>   
>   int perf_pmu__convert_scale(const char *scale, char **end, double *sval);