linux-kernel - Re: [PATCH 1/3] dt-bindings: pinctrl: Add compatibles for Amlogic T7 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cde944c4-acfe-b3fb-32b8-072740475e35@amlogic.com>
Date:   Thu, 14 Sep 2023 15:00:45 +0800
From:   Huqiang Qin <huqiang.qin@...ogic.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linus.walleij@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        neil.armstrong@...aro.org, khilman@...libre.com,
        jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
        brgl@...ev.pl, andy@...nel.org
Cc:     linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add compatibles for Amlogic T7
 SoCs

Hi Krzysztof,

On 2023/9/14 14:16, Krzysztof Kozlowski wrote:
...
>> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>> new file mode 100644
>> index 000000000000..2bab9a99501a
>> --- /dev/null
>> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h
> 
> Use compatible syntax.

The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory.
Does it also need to be named according to the compatible name of pinctrl?

> 
>> @@ -0,0 +1,179 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
>> + * Author: Huqiang Qin <huqiang.qin@...ogic.com>
>> + */
>> +
>> +#ifndef _DT_BINDINGS_AMLOGIC_T7_GPIO_H
>> +#define _DT_BINDINGS_AMLOGIC_T7_GPIO_H
>> +
>> +#define      GPIOB_0         0
> 
> Why weird indentation?

Okay, I didn't observe it, thanks for pointing it out.

...


Best regards,
Huqiang Qin