[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZQLADHCbOr5J8TpX@shell.armlinux.org.uk>
Date: Thu, 14 Sep 2023 09:10:52 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: James Morse <james.morse@....com>
Cc: linux-pm@...r.kernel.org, loongarch@...ts.linux.dev,
linux-acpi@...r.kernel.org, linux-arch@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-riscv@...ts.infradead.org, kvmarm@...ts.linux.dev,
x86@...nel.org, Salil Mehta <salil.mehta@...wei.com>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
jianyong.wu@....com, justin.he@....com
Subject: Re: [RFC PATCH v2 30/35] irqchip/gic-v3: Add support for ACPI's
disabled but 'online capable' CPUs
On Wed, Sep 13, 2023 at 04:38:18PM +0000, James Morse wrote:
> static inline bool acpi_gicc_is_usable(struct acpi_madt_generic_interrupt *gicc)
> {
> - return (gicc->flags & ACPI_MADT_ENABLED);
> + return ((gicc->flags & ACPI_MADT_ENABLED ||
> + gicc->flags & ACPI_MADT_GICC_CPU_CAPABLE));
... and this starts getting silly with the number of parens.
return gicc->flags & ACPI_MADT_ENABLED ||
gicc->flags & ACPI_MADT_GICC_CPU_CAPABLE;
is entirely sufficient. Also:
return gicc->flags & (ACPI_MADT_ENABLED | ACPI_MADT_GICC_CPU_CAPABLE);
also works.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists