[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bdc71fcc-2d72-a958-bb52-84f3fabb49cb@amlogic.com>
Date: Thu, 14 Sep 2023 16:24:18 +0800
From: Huqiang Qin <huqiang.qin@...ogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
linus.walleij@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
neil.armstrong@...aro.org, khilman@...libre.com,
jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
brgl@...ev.pl, andy@...nel.org
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: Add compatibles for Amlogic T7
SoCs
On 2023/9/14 15:19, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 14/09/2023 09:00, Huqiang Qin wrote:
>> Hi Krzysztof,
>>
>> On 2023/9/14 14:16, Krzysztof Kozlowski wrote:
>> ...
>>>> diff --git a/include/dt-bindings/gpio/amlogic-t7-gpio.h b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>>>> new file mode 100644
>>>> index 000000000000..2bab9a99501a
>>>> --- /dev/null
>>>> +++ b/include/dt-bindings/gpio/amlogic-t7-gpio.h
>>>
>>> Use compatible syntax.
>>
>> The amlogic-t7-gpio.h is not a file in the dt-bindings/pinctrl/ directory.
>> Does it also need to be named according to the compatible name of pinctrl?
>
> The convention, which we introduced since ~1-2 years, is to use the
> device compatible or binding filename as the headers filename. Now,
> where you put what does not affect it.
>
Okay, got it, I will modify it in the next version.
Thanks
Best regards,
Huqiang Qin
Powered by blists - more mailing lists