linux-kernel - Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7bebc22-d494-f54d-5543-db75f5714a52@ti.com>
Date:   Thu, 14 Sep 2023 14:56:29 +0530
From:   Nitin Yadav <n-yadav@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, <nm@...com>,
        <vigneshr@...com>, <rogerq@...com>
CC:     <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <catalin.marinas@....com>, <will@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support

Hi Krzysztof,

On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> On 13/09/2023 13:47, Nitin Yadav wrote:
>> Add support for AM62Q NAND card: X8 NAND EXPANSION
>> BOARD card (PROC143E1) for AM62x LP SK board.
>>
>> Signed-off-by: Nitin Yadav <n-yadav@...com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
>>  arch/arm64/boot/dts/ti/k3-am62.dtsi      |  2 ++
>>  2 files changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> index 284b90c94da8..e93e79d8083f 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@...0000 {
>>  		power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>>  		status = "disabled";
>>  	};
>> +	gpmc0: memory-controller@...00000 {
>> +		status = "disabled";
> 
> status is never first in DTSI. Really, where did you see such code?
Thank for pointing out, Will send a revised version.
> 
>> +		compatible = "ti,am64-gpmc";
>> +		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> 
> First is compatible, second is reg/reg-names/ranges.
> 
> 
> Best regards,
> Krzysztof
> 

-- 
Regards,
Nitin