[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202309141736.ABab8fuf-lkp@intel.com>
Date: Thu, 14 Sep 2023 17:34:22 +0800
From: kernel test robot <lkp@...el.com>
To: Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org
Cc: oe-kbuild-all@...ts.linux.dev, hannes@...xchg.org,
cerasuolodomenico@...il.com, yosryahmed@...gle.com,
sjenning@...hat.com, ddstreet@...e.org, vitaly.wool@...sulko.com,
mhocko@...nel.org, roman.gushchin@...ux.dev, shakeelb@...gle.com,
muchun.song@...ux.dev, linux-mm@...ck.org, kernel-team@...a.com,
linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Subject: Re: [PATCH 1/2] zswap: make shrinking memcg-aware
Hi Nhat,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.6-rc1 next-20230914]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/zswap-make-shrinking-memcg-aware/20230912-004147
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230911164024.2541401-2-nphamcs%40gmail.com
patch subject: [PATCH 1/2] zswap: make shrinking memcg-aware
config: loongarch-randconfig-001-20230914 (https://download.01.org/0day-ci/archive/20230914/202309141736.ABab8fuf-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309141736.ABab8fuf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309141736.ABab8fuf-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
mm/zswap.c: In function 'zswap_lru_add':
>> mm/zswap.c:320:17: error: implicit declaration of function 'get_mem_cgroup_from_objcg'; did you mean 'get_mem_cgroup_from_mm'? [-Werror=implicit-function-declaration]
320 | get_mem_cgroup_from_objcg(entry->objcg) : NULL;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| get_mem_cgroup_from_mm
>> mm/zswap.c:320:57: warning: pointer/integer type mismatch in conditional expression
320 | get_mem_cgroup_from_objcg(entry->objcg) : NULL;
| ^
mm/zswap.c: In function 'zswap_lru_del':
mm/zswap.c:330:57: warning: pointer/integer type mismatch in conditional expression
330 | get_mem_cgroup_from_objcg(entry->objcg) : NULL;
| ^
mm/zswap.c: In function 'shrink_memcg_cb':
mm/zswap.c:694:80: warning: pointer/integer type mismatch in conditional expression
694 | memcg = entry->objcg ? get_mem_cgroup_from_objcg(entry->objcg) : NULL;
| ^
mm/zswap.c: In function 'shrink_worker':
>> mm/zswap.c:758:51: error: invalid use of undefined type 'struct mem_cgroup'
758 | css_put(&pool->next_shrink->css);
| ^~
mm/zswap.c: In function 'zswap_pool_destroy':
mm/zswap.c:906:43: error: invalid use of undefined type 'struct mem_cgroup'
906 | css_put(&pool->next_shrink->css);
| ^~
mm/zswap.c: In function 'zswap_store':
>> mm/zswap.c:1298:23: warning: assignment to 'struct mem_cgroup *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1298 | memcg = get_mem_cgroup_from_objcg(objcg);
| ^
mm/zswap.c:1300:39: error: invalid use of undefined type 'struct mem_cgroup'
1300 | css_put(&memcg->css);
| ^~
mm/zswap.c:1303:31: error: invalid use of undefined type 'struct mem_cgroup'
1303 | css_put(&memcg->css);
| ^~
mm/zswap.c:1349:23: warning: assignment to 'struct mem_cgroup *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1349 | memcg = get_mem_cgroup_from_objcg(objcg);
| ^
mm/zswap.c:1351:31: error: invalid use of undefined type 'struct mem_cgroup'
1351 | css_put(&memcg->css);
| ^~
cc1: some warnings being treated as errors
vim +320 mm/zswap.c
313
314 /*********************************
315 * lru functions
316 **********************************/
317 static bool zswap_lru_add(struct list_lru *list_lru, struct zswap_entry *entry)
318 {
319 struct mem_cgroup *memcg = entry->objcg ?
> 320 get_mem_cgroup_from_objcg(entry->objcg) : NULL;
321 bool added = __list_lru_add(list_lru, &entry->lru, entry->nid, memcg);
322
323 mem_cgroup_put(memcg);
324 return added;
325 }
326
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists