linux-kernel - Re: [PATCH v4 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230914002255.GC3638268@ls.amr.corp.intel.com>
Date:   Wed, 13 Sep 2023 17:22:55 -0700
From:   Isaku Yamahata <isaku.yamahata@...ux.intel.com>
To:     "Huang, Kai" <kai.huang@...el.com>
Cc:     "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "bp@...en8.de" <bp@...en8.de>, "x86@...nel.org" <x86@...nel.org>,
        "hpa@...or.com" <hpa@...or.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "n.borisov.lkml@...il.com" <n.borisov.lkml@...il.com>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        isaku.yamahata@...ux.intel.com
Subject: Re: [PATCH v4 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly

On Tue, Sep 05, 2023 at 11:01:28PM +0000,
"Huang, Kai" <kai.huang@...el.com> wrote:

> On Tue, 2023-08-15 at 23:01 +1200, Kai Huang wrote:
> > Hi Peter, Kirill,
> > 
> > This series unifies the assembly code for TDCALL/SEAMCALL and TDVMCALL.
> > Now all of them use one singe TDX_MODULE_CALL asm macro.  More
> > information please see cover letter of v2 (see link below).
> > 
> > Tested by booting TDX guest, initializing TDX module, and running TDX
> > guest successfully, all with this series applied.
> > 
> > 
> 
> Hi Peter,
> 
> Sorry to ping, but could you take a look whether you are OK with this series?
> 
> Basically Kirill has provided his Reviewed-by for all the patches except the
> last one (Add unused registers to 'struct tdx_module_args' to optimize VP.ENTER
> for KVM), which he didn't like.  But it is pretty much a standalone optimization
> patch we either can have or drop when applying, so I'll leave to you.
> 
> Also feel free to let me know if I can help you on anything to offload part of
> your load? :-)

Because the optimization patch was dropped in tip x86/tdx tree, TDX KVM can't
use __seamcall_saved_ret() because the argument doesn't match.  There is no
user of __seamcall_saved_ret().
-- 
Isaku Yamahata <isaku.yamahata@...ux.intel.com>