linux-kernel - Re: [PATCH] nvmem: brcm_nvram: store a copy of NVRAM content

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0545951a0e787792c5cc20eca66a72a@milecki.pl>
Date:   Thu, 14 Sep 2023 10:02:47 +0200
From:   Rafał Miłecki <rafal@...ecki.pl>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Scott Branden <scott.branden@...adcom.com>
Subject: Re: [PATCH] nvmem: brcm_nvram: store a copy of NVRAM content

On 2023-09-14 09:56, Arınç ÜNAL wrote:
> On 14.09.2023 09:49, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@...ecki.pl>
>> 
>> This driver uses MMIO access for reading NVRAM from a flash device.
>> Underneath there is a flash controller that reads data and provides
>> mapping window.
>> 
>> Using MMIO interface affects controller configuration and may break 
>> real
>> controller driver. It was reported by multiple users of devices with
>> NVRAM stored on NAND.
>> 
>> Modify driver to read & cache all NVRAM content during init and use 
>> that
>> copy to provide NVMEM data when requested.
>> 
>> Link: 
>> https://lore.kernel.org/linux-mtd/CACna6rwf3_9QVjYcM+847biTX=K0EoWXuXcSMkJO1Vy_5vmVqA@mail.gmail.com/
>> Cc: Arınç ÜNAL <arinc.unal@...nc9.com>
>> Cc: Florian Fainelli <florian.fainelli@...adcom.com>
>> Cc: Scott Branden <scott.branden@...adcom.com>
>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> 
> This is a bug fix, could you add a "Fixes" tag so it will be backported 
> to
> stable releases?

I suppose we could try:
Fixes: 3fef9ed0627a ("nvmem: brcm_nvram: new driver exposing Broadcom's 
NVRAM")

Srini: can you append it while applying if you find it OK?

-- 
Rafał Miłecki