[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230915142955.h4sndeix2begarl5@dhruva>
Date: Fri, 15 Sep 2023 19:59:55 +0530
From: Dhruva Gole <d-gole@...com>
To: Mark Brown <broonie@...nel.org>
CC: <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Vignesh Raghavendra <vigneshr@...com>,
kernel test robot <lkp@...el.com>,
Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto
warnings
On Sep 15, 2023 at 13:49:23 +0100, Mark Brown wrote:
> On Fri, Sep 15, 2023 at 06:01:04PM +0530, Dhruva Gole wrote:
> > Fix the smatch warnings that were recently introduced in the runtime pm
> > patch [0]:
> > drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
> > unwind goto?
> >
> > [0] https://lore.kernel.org/all/20230829062706.786637-1-d-gole@ti.com/
>
> Please use normal fixes tags for things like this and in general
OK, I will resend with fixes tag.
> please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on trains or flights, or while
> otherwise travelling so this is even more pressing for me than just
> being about making things a bit easier to read.
Will keep this in mind!
Also, I think a better fix will do, as I just noticed I am not really
doing a dma_release_channel in this path although I got rid of the
warning.
--
Best regards,
Dhruva Gole <d-gole@...com>
Powered by blists - more mailing lists