linux-kernel - Re: [PATCH v3 5/6] can: tcan4x5x: Add support for tcan4552/4553

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a94e6fc8-4f08-7877-2ba0-29b9c2780136@seco.com>
Date:   Fri, 15 Sep 2023 11:36:49 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     Markus Schneider-Pargmann <msp@...libre.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Chandrasekar Ramakrishnan <rcsekar@...sung.com>,
        Michal Kubiak <michal.kubiak@...el.com>,
        Vivek Yadav <vivek.2311@...sung.com>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Simon Horman <simon.horman@...igine.com>
Subject: Re: [PATCH v3 5/6] can: tcan4x5x: Add support for tcan4552/4553

On 7/21/23 09:50, Markus Schneider-Pargmann wrote:
> +static const struct tcan4x5x_version_info tcan4x5x_versions[] = {
> +	[TCAN4552] = {
> +		.name = "4552",
> +		.id2_register = 0x32353534,
> +	},
> +	[TCAN4553] = {
> +		.name = "4553",
> +		.id2_register = 0x32353534,

Should this be 0x33353534?

> +	},
> +	/* generic version with no id2_register at the end */
> +	[TCAN4X5X] = {
> +		.name = "generic",
> +		.has_wake_pin = true,
> +		.has_state_pin = true,
> +	},
> +};

--Sean