linux-kernel - Re: [RFC] usb: gadget: ncm: Handle decoding of multiple NTB's in unwrap call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2023 08:16:18 +0530
From:   Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
To:     Maciej Żenczykowski <maze@...gle.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linyu Yuan <quic_linyyuan@...cinc.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_ppratap@...cinc.com>, <quic_wcheng@...cinc.com>,
        <quic_jackp@...cinc.com>
Subject: Re: [RFC] usb: gadget: ncm: Handle decoding of multiple NTB's in
 unwrap call

On 9/15/2023 6:54 AM, Maciej Żenczykowski wrote:
> Reviewed-by: Maciej Żenczykowski <maze@...gle.com>
> 
> The casts should probably use the actual correct ptr type instead of void*
> 

Hi Maciej Żenczykowski,

Thanks for the review.

I initially tried to typecast it to char* since the skb->data is of that 
type. But nothing was working. So I kept it void* since the initial 
variable tmp too was kept to void*

Will add the stable and review tag as well and send v2 to be merged.

Regards,
Krishna,