linux-kernel - Re: [PATCH v1] dynamic_debug: add support for logs destination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfuBxyFYyGCtr5i=P7N=1oX3J=jmdp1VLGLt+z1fAnuvGK2aA@mail.gmail.com>
Date:   Fri, 15 Sep 2023 12:02:04 -0600
From:   jim.cromie@...il.com
To:     Łukasz Bartosik <lb@...ihalf.com>
Cc:     Jason Baron <jbaron@...mai.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Guenter Roeck <groeck@...gle.com>,
        Yaniv Tzoreff <yanivt@...gle.com>,
        Benson Leung <bleung@...gle.com>, linux-kernel@...r.kernel.org,
        upstream@...ihalf.com,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v1] dynamic_debug: add support for logs destination

On Fri, Sep 15, 2023 at 9:49 AM Łukasz Bartosik <lb@...ihalf.com> wrote:
>
> Add support for selection of dynamic debug logs destination.
> When enabled it allows to configure destination of each callsite
> individually. The option adds a framework (described by struct
> ddebug_dst_ops) which provides flexible means to add a new destination
> for debug logs. On top of the framework support for trace instance as
> destination is added. By default destination of debug logs is syslog.
> Syslog can be set explicitly by using dst keyword or is selected by
> default when dst keyword is omitted, for example:

A while back,
Cc: Vincent Whitchurch <vincent.whitchurch@...s.com>
proposed these patches:
      https://lore.kernel.org/lkml/20200825153338.17061-1-vincent.whitchurch@axis.com/

his approach adds a single flag, +x or (my pref) +T
which sends the pr_debug to tracefs, independent of +p.
Steve Rostedt offered feedback on one of the versions,
and one could read that as provisional acceptance.

Ive worked his patchset since, it is here:
https://github.com/jimc/linux/tree/dd-trc-11
(it has some unrelated bits too)

but it sits atop another patchset:
https://lore.kernel.org/lkml/20230911230838.14461-1-jim.cromie@gmail.com/
or for git remote add
https://github.com/jimc/linux/tree/dd-fix-5i


syslog and/or tracefs seems sufficient, do you have a 3rd destination ?

thanks