linux-kernel - Re: [GIT PULL] tracing: Add eventfs file to help with debugging any more issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whNU3JaPMq_E7mwVGpTKxxeQxV=13o84u-tTeqfB_t05g@mail.gmail.com>
Date:   Fri, 15 Sep 2023 13:50:17 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ajay Kaher <akaher@...are.com>
Subject: Re: [GIT PULL] tracing: Add eventfs file to help with debugging any
 more issues

On Fri, 15 Sept 2023 at 13:36, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> I'm OK with it not going in now, but instead I'll wrap an ifdef around it
> and move it to my queue for the next merge window. I still would like to
> keep these "what's going on internally" available, as I'll ask people to
> enable them when they report an issue.

Honestly, you copied the pattern from the /proc filesystem.

The /proc filesyustem is widely used and has never had this kind of
random debugging code in mainline.

Seriously, that eventfs_file thing is not worthy of this kind of
special debug code.

That debug code seems to be approaching the same order of size as all
the code evetfs_file code itself is.

There's a point where this kind of stuff just becomes ridiculous. At
least wait until there's a *reason* to debug a simple linked list of
objects.

If you have a hard time figuring out what the eventfs entries are,
maybe you should just have made "iterate_shared" show them, and then
you could use fancy tools like "ls" to see what the heck is up in that
directory?

                 Linus