linux-kernel - Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5GJxEobJKKWuc_UN+Gf_z8g6eb6KWTz-L+RqtyLYKK3Jg@mail.gmail.com>
Date:   Fri, 15 Sep 2023 13:28:04 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Jani Nikula <jani.nikula@...el.com>
Cc:     dri-devel@...ts.freedesktop.org,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Guillaume Ranquet <granquet@...libre.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Markus Schneider-Pargmann <msp@...libre.com>,
        Bo-Chen Chen <rex-bc.chen@...iatek.com>,
        linux-mediatek@...ts.infradead.org,
        Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback
 audio detection

On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula <jani.nikula@...el.com> wrote:
>
> The sads returned by drm_edid_to_sad() needs to be freed.
>
> Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195")
> Cc: Guillaume Ranquet <granquet@...libre.com>
> Cc: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Cc: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Matthias Brugger <matthias.bgg@...il.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-mediatek@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: <stable@...r.kernel.org> # v6.1+
> Signed-off-by: Jani Nikula <jani.nikula@...el.com>

Looks correct to me.

Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>