linux-kernel - Re: [PATCH 11/12] riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acd83ee9-951d-928c-eb9f-e3295ae7ad55@linaro.org>
Date:   Fri, 15 Sep 2023 09:32:08 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Wang Chen <unicornxw@...il.com>, linux-riscv@...ts.infradead.org,
        conor@...nel.org, aou@...s.berkeley.edu,
        krzysztof.kozlowski+dt@...aro.org, palmer@...belt.com,
        paul.walmsley@...ive.com, robh+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        jszhang@...nel.org, guoren@...nel.org, chao.wei@...hgo.com,
        xiaoguang.xing@...hgo.com, Wang Chen <wangchen20@...as.ac.cn>,
        Emil Renner Berthing <emil.renner.berthing@...onical.com>
Subject: Re: [PATCH 11/12] riscv: dts: sophgo: Add sophgo,sg2024-uart
 compatibles

On 15/09/2023 09:26, Wang Chen wrote:
> Add compatible for uart.
> 
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>
> Signed-off-by: Wang Chen <wangchen20@...as.ac.cn>
> ---
>  arch/riscv/boot/dts/sophgo/sg2042.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index 5c4b82f13207..87f7667bbe63 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -492,7 +492,7 @@ &cpu63_intc  0xffffffff &cpu63_intc  9
>  		};
>  
>  		uart0: serial@...0000000 {
> -			compatible = "snps,dw-apb-uart";
> +			compatible = "sophgo,sg2042-uart", "snps,dw-apb-uart";

No, you just added this file. Do not add buggy code which is fixed in
next patch.

Best regards,
Krzysztof