linux-kernel - Re: [PATCH] drm/mediatek: dsi: Fix EOTp generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b0dde15-12e3-713e-a2f9-9b2534691476@collabora.com>
Date:   Fri, 15 Sep 2023 11:02:22 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Michael Walle <mwalle@...nel.org>
Cc:     Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Jitao Shi <jitao.shi@...iatek.com>,
        dri-devel@...ts.freedesktop.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm/mediatek: dsi: Fix EOTp generation

Il 15/09/23 11:01, Michael Walle ha scritto:
> Hi,
> 
> Am 2023-09-15 10:58, schrieb AngeloGioacchino Del Regno:
>> Il 15/09/23 09:57, Michael Walle ha scritto:
>>> The commit c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register
>>> definition") inverted the logic of the control bit. Maybe it was because
>>> of the bad naming which was fixed in commit 0f3b68b66a6d ("drm/dsi: Add
>>> _NO_ to MIPI_DSI_* flags disabling features"). In any case, the logic
>>> wrong and there will be no EOTp on the DSI link by default. Fix it.
>>>
>>> Fixes: c87d1c4b5b9a ("drm/mediatek: dsi: Use symbolized register definition")
>>> Signed-off-by: Michael Walle <mwalle@...nel.org>
>>
>> Hello Michael,
>> your commit is missing a small piece! :-)
>>
>> Besides, I've already sent a fix for what you're trying to do here:
>> https://lore.kernel.org/linux-arm-kernel/07c93d61-c5fd-f074-abb2-73fdaa81fd65@collabora.com/T/
> 
> Ahh thanks, didn't noticed this. If not already applied, I'll send
> a Tested-by: later.
> 

No worries, it happens.

Cheers,
Angelo

> Please disregard this patch then.
> 
> -michael