linux-kernel - Re: [PATCH] crypto: qcom-rng: Add hwrng support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQQvlXvGy8p01uJS@gondor.apana.org.au>
Date:   Fri, 15 Sep 2023 18:19:01 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Om Prakash Singh <quic_omprsing@...cinc.com>
Cc:     neil.armstrong@...aro.org, konrad.dybcio@...aro.org,
        agross@...nel.org, andersson@...nel.org, conor+dt@...nel.org,
        davem@...emloft.net, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        marijn.suijten@...ainline.org, robh+dt@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH] crypto: qcom-rng: Add hwrng support

On Fri, Sep 01, 2023 at 06:45:02PM +0530, Om Prakash Singh wrote:
>
> +	qrng = (struct qcom_rng *)rng->priv;

Please stop using rng->priv, it is obsolete.  Instead embed the
rng object inside qcom_rng.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt