[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230915123103.2493640-1-d-gole@ti.com>
Date: Fri, 15 Sep 2023 18:01:04 +0530
From: Dhruva Gole <d-gole@...com>
To: Mark Brown <broonie@...nel.org>
CC: <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Vignesh Raghavendra <vigneshr@...com>,
Dhruva Gole <d-gole@...com>, kernel test robot <lkp@...el.com>,
Dan Carpenter <dan.carpenter@...aro.org>
Subject: [PATCH] spi: spi-cadence-quadspi: Fix missing unwind goto warnings
Fix the smatch warnings that were recently introduced in the runtime pm
patch [0]:
drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
unwind goto?
[0] https://lore.kernel.org/all/20230829062706.786637-1-d-gole@ti.com/
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/r/202309140543.03dMbMM5-lkp@intel.com/
Signed-off-by: Dhruva Gole <d-gole@...com>
---
Link: https://lore.kernel.org/r/20230915123103.2493640-1-d-gole@ti.com
Tested locally using the following cmd:
make -j32 ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- drivers/spi/spi-cadence-quadspi.o CHECK="smatch -p=kernel" C=1 W=1
drivers/spi/spi-cadence-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 4828da4587c5..e04f257c1067 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -1879,7 +1879,7 @@ static int cqspi_probe(struct platform_device *pdev)
ret = devm_pm_runtime_enable(dev);
if (ret)
- return ret;
+ goto probe_setup_failed;
pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
pm_runtime_use_autosuspend(dev);
--
2.34.1
Powered by blists - more mailing lists