linux-kernel - Re: [PATCH] net: sched: hfsc: dont intepret cls results when asked to drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+hM_eHSPUNwPCQZdtkk7O31GhaQ4AmhfBuZ=wQ3psb7w@mail.gmail.com>
Date:   Fri, 15 Sep 2023 14:57:35 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Ma Ke <make_ruc2021@....com>
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sched: hfsc: dont intepret cls results when asked to drop

On Fri, Sep 15, 2023 at 2:37 PM Ma Ke <make_ruc2021@....com> wrote:
>
> If asked to drop a packet via TC_ACT_SHOT it is unsafe to assume
> res.class contains a valid pointer.
>
> Signed-off-by: Ma Ke <make_ruc2021@....com>
> ---
>  net/sched/sch_hfsc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
> index 3554085bc2be..2a76027b14e6 100644
> --- a/net/sched/sch_hfsc.c
> +++ b/net/sched/sch_hfsc.c
> @@ -1135,6 +1135,8 @@ hfsc_classify(struct sk_buff *skb, struct Qdisc *sch, int *qerr)
>         head = &q->root;
>         tcf = rcu_dereference_bh(q->root.filter_list);
>         while (tcf && (result = tcf_classify(skb, NULL, tcf, &res, false)) >= 0) {
> +               if (result == TC_ACT_SHOT)
> +                       return NULL;
>  #ifdef CONFIG_NET_CLS_ACT
>                 switch (result) {
>                 case TC_ACT_QUEUED:
> --
> 2.37.2
>

Same comment, already handled at iine 1145