[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAC0WRTWr66kUnaTvdJXWP=hw1MmXB=5R+zqn0OgOqNqGr==BdQ@mail.gmail.com>
Date: Fri, 15 Sep 2023 21:14:34 +0800
From: Zhang LongQi <longqi90@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/Allwinner sunXi SoC support"
<linux-sunxi@...ts.linux.dev>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fixes the pin settings of two LEDs on board nanopi neo plus2
Thanks Krzysztof, I will modify and submit.
sorry for the previous email which is the html format.
On Mon, Sep 11, 2023 at 10:42 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 11/09/2023 16:09, longqi wrote:
> > Signed-off-by: longqi <longqi90@...il.com>
>
> Thank you for your patch. There is something to discuss/improve.
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
>
> Your commit msg is missing. Please describe the bug or the problem thus
> it will be obvious why this change is needed.
>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists