linux-kernel - Re: [PATCH] mm/rmap: convert __page_check_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQRg89X67vKL8Q4d@casper.infradead.org>
Date:   Fri, 15 Sep 2023 14:49:39 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/rmap: convert __page_check_anon_rmap() to folio

On Fri, Sep 15, 2023 at 06:17:31PM +0800, Yajun Deng wrote:
> @@ -1176,8 +1175,8 @@ static void __page_check_anon_rmap(struct folio *folio, struct page *page,
>  	 */
>  	VM_BUG_ON_FOLIO(folio_anon_vma(folio)->root != vma->anon_vma->root,
>  			folio);
> -	VM_BUG_ON_PAGE(page_to_pgoff(page) != linear_page_index(vma, address),
> -		       page);
> +	VM_BUG_ON_FOLIO(folio_pgoff(folio) != linear_page_index(vma, address),
> +		       folio);

No, this is not equivalent.  You haven't hit any problems testing it
because you don't have large anonymous folios.