[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20230916061718.336-1-rohan.g.thomas@intel.com>
Date: Sat, 16 Sep 2023 14:17:18 +0800
From: rohan.g.thomas@...el.com
To: robh@...nel.org
Cc: alexandre.torgue@...s.st.com, conor+dt@...nel.org,
davem@...emloft.net, devicetree@...r.kernel.org,
edumazet@...gle.com, fancer.lancer@...il.com, joabreu@...opsys.com,
krzysztof.kozlowski+dt@...aro.org, kuba@...nel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
pabeni@...hat.com, peppe.cavallaro@...com, rohan.g.thomas@...el.com
Subject: Re: [linux-drivers-review] [PATCH net-next v2 1/3] net: stmmac: xgmac: EST interrupts handling
From: Rohan G Thomas <rohan.g.thomas@...el.com>
Thanks for the review comments.
Will address this in the next version.
On Fri, Sep 15, 2023 at 05:54:16PM +0800, Rohan G Thomas wrote:
>> Add dt-bindings for coe-unsupported property per tx queue.
>
>Why? (What every commit msg should answer)
>
>>
>> Signed-off-by: Rohan G Thomas <rohan.g.thomas@...el.com>
>> ---
>> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index ddf9522a5dc2..365e6cb73484 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -394,6 +394,9 @@ properties:
>> When a PFC frame is received with priorities matching the bitmask,
>> the queue is blocked from transmitting for the pause time specified
>> in the PFC frame.
>
>blank line needed
>
>> + snps,coe-unsupported:
>> + type: boolean
>> + description: TX checksum offload is unsupported by the TX queue.
>
>And here.
>
>> allOf:
>> - if:
>> required:
>> --
>> 2.25.1
>>
Powered by blists - more mailing lists