linux-kernel - Re: [PATCH net 5/5] net: hns3: add 5ms delay before clear firmware reset irq source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230916153106.GE1125562@kernel.org>
Date:   Sat, 16 Sep 2023 17:31:06 +0200
From:   Simon Horman <horms@...nel.org>
To:     Jijie Shao <shaojijie@...wei.com>
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, shenjian15@...wei.com, wangjie125@...wei.com,
        liuyonglong@...wei.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 5/5] net: hns3: add 5ms delay before clear firmware
 reset irq source

On Fri, Sep 15, 2023 at 05:53:05PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@...wei.com>
> 
> Currently the reset process in hns3 and firmware watchdog init process is
> asynchronous. we think firmware watchdog initialization is completed
> before hns3 clear the firmware interrupt source. However, firmware
> initialization may not complete early.
> 
> so we add delay before hns3 clear firmware interrupt source and 5 ms delay
> is enough to avoid second firmware reset interrupt.
> 
> Signed-off-by: Jie Wang <wangjie125@...wei.com>
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Hi Jijie Shao,

is it appropriate to add the following tag?

Fixes: c1a81619d73a ("net: hns3: Add mailbox interrupt handling to PF driver")