linux-kernel - Re: [PATCH] selftests: ALSA: fix warnings in 'test-pcmtest-driver'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1c8d747-dcf6-a913-f6d5-37fdfe3e2be6@gmail.com>
Date:   Sat, 16 Sep 2023 23:16:26 +0400
From:   Ivan Orlov <ivan.orlov0322@...il.com>
To:     Javier Carrasco <javier.carrasco.cruz@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Shuah Khan <shuah@...nel.org>
Cc:     alsa-devel@...a-project.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: ALSA: fix warnings in 'test-pcmtest-driver'

On 9/16/23 22:25, Javier Carrasco wrote:
> Removing an unused variable is actually removing a blank line from a
> logical point of view. Is an extra patch not overkill considering that
> it cannot affect the code behavior?

Well, no, it is not, as the line is not blank (nothing except removing a 
blank line could be considered as blank line removal) :) And an extra 
patch is not an overkill in case if you are separating logical changes.

However, rules may vary from one subsystem to another, so it is up to 
Shuah to decide take this patch or not. My opinion is that such changes 
should be separated into different patches.