Message-ID: <878r95nbvt.fsf@jogness.linutronix.de>
Date:   Sat, 16 Sep 2023 21:48:14 +0206
From:   John Ogness <john.ogness@...utronix.de>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        Petr Mladek <pmladek@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Tobias Klauser <tklauser@...tanz.ch>,
        Thierry Reding <treding@...dia.com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, Al Cooper <alcooperx@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Tony Lindgren <tony@...mide.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Davis <afd@...com>,
        Matthew Howell <matthew.howell@...level.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Johan Hovold <johan@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Chen-Yu Tsai <wenst@...omium.org>,
        linux-mediatek@...ts.infradead.org, Lukas Wunner <lukas@...ner.de>,
        Matthias Schiffer <matthias.schiffer@...tq-group.com>,
        Arnd Bergmann <arnd@...db.de>,
        Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>,
        Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>,
        Russell King <linux@...linux.org.uk>,
        "Maciej W. Rozycki" <macro@...am.me.uk>,
        Hongyu Xie <xiehongyu1@...inos.cn>,
        Jiamei Xie <jiamei.xie@....com>, Rob Herring <robh@...nel.org>,
        delisun <delisun@...eo.com.cn>,
        Lino Sanfilippo <l.sanfilippo@...bus.com>,
        Yangtao Li <frank.li@...o.com>,
        Vineet Gupta <vgupta@...nel.org>,
        linux-snps-arc@...ts.infradead.org,
        Richard Genoud <richard.genoud@...il.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...on.dev>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Baruch Siach <baruch@...s.co.il>,
        Sherry Sun <sherry.sun@....com>,
        Shenwei Wang <shenwei.wang@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Sergey Organov <sorganov@...il.com>, Tom Rix <trix@...hat.com>,
        Marek Vasut <marex@...x.de>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Gabriel Somlo <gsomlo@...il.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Jacky Huang <ychuang3@...oton.com>,
        Shan-Chun Hung <schung@...oton.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Dmitry Rokosov <ddrokosov@...rdevices.ru>,
        Lucas Tanure <tanure@...ux.com>,
        linux-amlogic@...ts.infradead.org,
        Taichi Sugaya <sugaya.taichi@...ionext.com>,
        Takao Orito <orito.takao@...ionext.com>,
        Liviu Dudau <liviu.dudau@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andreas Färber <afaerber@...e.de>,
        Manivannan Sadhasivam <mani@...nel.org>,
        linux-actions@...ts.infradead.org,
        Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        Yuan Can <yuancan@...wei.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-unisoc@...ts.infradead.org,
        Kevin Cernekee <cernekee@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        linux-samsung-soc@...r.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Lech Perczak <lech.perczak@...lingroup.com>,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Isaac True <isaac.true@...onical.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-tegra@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Nick Hu <nick.hu@...ive.com>,
        Ruan Jinjie <ruanjinjie@...wei.com>,
        Samuel Holland <samuel.holland@...ive.com>,
        linux-riscv@...ts.infradead.org, Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Valentin Caron <valentin.caron@...s.st.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-stm32@...md-mailman.stormreply.com,
        "David S. Miller" <davem@...emloft.net>,
        sparclinux@...r.kernel.org, Hammer Hsieh <hammerh0314@...il.com>,
        Peter Korsgaard <jacmet@...site.dk>,
        Timur Tabi <timur@...nel.org>,
        Mukesh Ojha <quic_mojha@...cinc.com>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Michal Simek <michal.simek@....com>
Subject: Re: [PATCH tty v1 00/74] serial: wrappers for uart port lock

On 2023-09-15, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:
> Would this also be useful to enable printing to console while under
> port's lock (by postponing the output until the lock is released)?
>
> E.g., 8250_dw.c has had this commented out since the dawn on time:
>         /*
>          * FIXME: this deadlocks if port->lock is already held
>          * dev_err(p->dev, "Couldn't set LCR to %d\n", value);
>          */

Yes, this will fix such issues. However, only for consoles that are
converted to the new NBCON console type.

Good news, the 8250 driver will be the flagship driver that is converted
as part of the rework. So this particular issue will be solved then. I
will try to remember this so that I can remove the FIXME in the series.

Thanks for mentioning it.

John

Powered by blists - more mailing lists