| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHAQgRDtQDx-DBSs6Afs_C3qrRDxqONENM9rXu43dWCw0ehXPA@mail.gmail.com>
Date: Sat, 16 Sep 2023 08:23:45 +0800
From: Chen Wang <unicornxw@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-riscv@...ts.infradead.org, conor@...nel.org,
aou@...s.berkeley.edu, krzysztof.kozlowski+dt@...aro.org,
palmer@...belt.com, paul.walmsley@...ive.com, robh+dt@...nel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
jszhang@...nel.org, guoren@...nel.org, chao.wei@...hgo.com,
xiaoguang.xing@...hgo.com, Wang Chen <wangchen20@...as.ac.cn>,
Inochi Amaoto <inochiama@...look.com>
Subject: Re: [PATCH 07/12] riscv: dts: add initial SOPHGO SG2042 SoC device tree
Thanks for your input, Krzysztof, I will correct these in next revision.
Regards,
unicornx
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 于2023年9月15日周五 15:28写道：
>
> On 15/09/2023 09:24, Wang Chen wrote:
> > Milk-V Pioneer motherboard is powered by SOPHON's SG2042.
> >
> > SG2042 is server grade chip with high performance, low power
> > consumption and high data throughput.
> > Key features:
> > - 64 RISC-V cpu cores which implements IMAFDC
> > - 4 cores per cluster, 16 clusters on chip
> > - ......
> >
> > More info is available at [1].
> >
> > [1]: https://en.sophgo.com/product/introduce/sg2042.html
> >
> > Currently only support booting into console with only uart
> > enabled, other features will be added soon later.
> >
> > Signed-off-by: Xiaoguang Xing <xiaoguang.xing@...hgo.com>
> > Signed-off-by: Inochi Amaoto <inochiama@...look.com>
> > Signed-off-by: Wang Chen <wangchen20@...as.ac.cn>
> > ---
> > MAINTAINERS | 1 +
> > arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi | 1794 +++++++++++++++++++
> > arch/riscv/boot/dts/sophgo/sg2042.dtsi | 513 ++++++
> > 3 files changed, 2308 insertions(+)
> > create mode 100644 arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi
> > create mode 100644 arch/riscv/boot/dts/sophgo/sg2042.dtsi
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 0e0d477dab38..b74d505003e2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20068,6 +20068,7 @@ M: Xiaoguang Xing <xiaoguang.xing@...hgo.com>
> > M: Chao Wei <chao.wei@...hgo.com>
> > S: Maintained
> > F: Documentation/devicetree/bindings/riscv/sophgo.yaml
> > +F: arch/riscv/boot/dts/sophgo/
> >
> > SOUND
> > M: Jaroslav Kysela <perex@...ex.cz>
> > diff --git a/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi b/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi
> > new file mode 100644
> > index 000000000000..0b6cd3559693
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi
> > @@ -0,0 +1,1794 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2022 Sophgo Technology Inc. All rights reserved.
> > + */
> > +
> > +/ {
>
>
> ..
> > +
> > + cpu0: cpu@0 {
> > + compatible = "thead,c920", "riscv";
> > + device_type = "cpu";
> > + riscv,isa = "rv64imafdc";
> > + reg = <0>;
> > + i-cache-block-size = <64>;
> > + i-cache-size = <65536>;
> > + i-cache-sets = <512>;
> > + d-cache-block-size = <64>;
> > + d-cache-size = <65536>;
> > + d-cache-sets = <512>;
> > + next-level-cache = <&l2_cache0>;
> > + mmu-type = "riscv,sv39";
> > + numa-node-id = <0>;
> > + status = "okay";
>
> Drop, it's by defualt. This applies everywhere.
>
> > +
> > + cpu0_intc: interrupt-controller {
> > + compatible = "riscv,cpu-intc";
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > + };
> > + };
>
> Missing blank line
>
> > + cpu1: cpu@1 {
> > + compatible = "thead,c920", "riscv";
> > + device_type = "cpu";
> > + riscv,isa = "rv64imafdc";
> > + reg = <1>;
> > + i-cache-block-size = <64>;
> > + i-cache-size = <65536>;
> > + i-cache-sets = <512>;
> > + d-cache-block-size = <64>;
> > + d-cache-size = <65536>;
> > + d-cache-sets = <512>;
> > + next-level-cache = <&l2_cache0>;
> > + mmu-type = "riscv,sv39";
> > + numa-node-id = <0>;
> > + status = "okay";
> > +
> > + cpu1_intc: interrupt-controller {
> > + compatible = "riscv,cpu-intc";
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > + };
> > + };
>
> Missing blank line. This applies everywhere.
>
> > + cpu2: cpu@2 {
> > + compatible = "thead,c920", "riscv";
> > + device_type = "cpu";
> > + riscv,isa = "rv64imafdc";
> > + reg = <2>;
> > + i-cache-block-size = <64>;
> > + i-cache-size = <65536>;
> > + i-cache-sets = <512>;
> > + d-cache-block-size = <64>;
> > + d-cache-size = <65536>;
> > + d-cache-sets = <512>;
> > + next-level-cache = <&l2_cache0>;
> > + mmu-type = "riscv,sv39";
> > + numa-node-id = <0>;
> > + status = "okay";
> > +
> > + cpu2_intc: interrupt-controller {
> > + compatible = "riscv,cpu-intc";
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> > + };
>
>
> > +
> > + l2_cache0: l2-cache@0 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
>
> Missing blank line
>
> > + l2_cache1: l2-cache@1 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
>
> Missing blank line
>
> > + l2_cache2: l2-cache@2 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache3: l2-cache@3 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache4: l2-cache@4 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache5: l2-cache@5 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache6: l2-cache@6 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache7: l2-cache@7 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache8: l2-cache@8 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache9: l2-cache@9 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache10: l2-cache@10 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache11: l2-cache@11 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache12: l2-cache@12 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache13: l2-cache@13 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache14: l2-cache@14 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + l2_cache15: l2-cache@15 {
> > + compatible = "cache";
> > + cache-block-size = <64>;
> > + cache-level = <2>;
> > + cache-size = <1048576>;
> > + cache-sets = <1024>;
> > + cache-unified;
> > + };
> > + };
> > +};
> > diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> > new file mode 100644
> > index 000000000000..5c4b82f13207
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> > @@ -0,0 +1,513 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2022 Sophgo Technology Inc. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +#include "sg2042-cpus.dtsi"
> > +
> > +#define SOC_PERIPHERAL_IRQ(nr) (nr)
> > +
> > +/ {
> > + compatible = "sophgo,sg2042";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + dma-noncoherent;
> > +
> > + distance-map {
> > + compatible = "numa-distance-map-v1";
> > + distance-matrix = <0 0 10>,
> > + <0 1 15>,
> > + <0 2 25>,
> > + <0 3 30>,
> > + <1 0 15>,
> > + <1 1 10>,
> > + <1 2 30>,
> > + <1 3 25>,
> > + <2 0 25>,
> > + <2 1 30>,
> > + <2 2 10>,
> > + <2 3 15>,
> > + <3 0 30>,
> > + <3 1 25>,
> > + <3 2 15>,
> > + <3 3 10>;
> > + };
> > +
> > + /* the mem node will be updated by ZSBL. */
> > + memory@0 {
> > + device_type = "memory";
> > + reg = <0x00000000 0x00000000 0x00000000 0x00000000>;
> > + numa-node-id = <0>;
> > + };
> > + memory@1 {
> > + device_type = "memory";
> > + reg = <0x00000000 0x00000001 0x00000000 0x00000000>;
> > + numa-node-id = <1>;
> > + };
> > + memory@2 {
> > + device_type = "memory";
> > + reg = <0x00000000 0x00000002 0x00000000 0x00000000>;
> > + numa-node-id = <2>;
> > + };
> > + memory@3 {
> > + device_type = "memory";
> > + reg = <0x00000000 0x00000003 0x00000000 0x00000000>;
> > + numa-node-id = <3>;
> > + };
> > +
> > + reserved-memory {
> > + #address-cells = <0x2>;
> > + #size-cells = <0x2>;
> > + ranges;
>
> Missing blank line
>
> > + linux,cma {
> > + compatible = "shared-dma-pool";
> > + size = <0x00000000 0x10000000>;
> > + alloc-ranges = <0x00000000 0xc0000000
> > + 0x00000000 0xd0000000>;
> > + reusable;
> > + linux,cma-default;
> > + };
> > + };
> > +
> > + pmu {
> > + compatible = "riscv,pmu";
> > + riscv,event-to-mhpmevent =
> > + <0x00003 0x00000000 0x00000010>,
> > + <0x00004 0x00000000 0x00000011>,
> > + <0x00005 0x00000000 0x00000007>,
> > + <0x00006 0x00000000 0x00000006>,
> > + <0x00008 0x00000000 0x00000027>,
> > + <0x00009 0x00000000 0x00000028>,
> > + <0x10000 0x00000000 0x0000000c>,
> > + <0x10001 0x00000000 0x0000000d>,
> > + <0x10002 0x00000000 0x0000000e>,
> > + <0x10003 0x00000000 0x0000000f>,
> > + <0x10008 0x00000000 0x00000001>,
> > + <0x10009 0x00000000 0x00000002>,
> > + <0x10010 0x00000000 0x00000010>,
> > + <0x10011 0x00000000 0x00000011>,
> > + <0x10012 0x00000000 0x00000012>,
> > + <0x10013 0x00000000 0x00000013>,
> > + <0x10019 0x00000000 0x00000004>,
> > + <0x10021 0x00000000 0x00000003>,
> > + <0x10030 0x00000000 0x0000001c>,
> > + <0x10031 0x00000000 0x0000001b>;
> > + riscv,event-to-mhpmcounters =
> > + <0x00003 0x00003 0xfffffff8>,
> > + <0x00004 0x00004 0xfffffff8>,
> > + <0x00005 0x00005 0xfffffff8>,
> > + <0x00006 0x00006 0xfffffff8>,
> > + <0x00007 0x00007 0xfffffff8>,
> > + <0x00008 0x00008 0xfffffff8>,
> > + <0x00009 0x00009 0xfffffff8>,
> > + <0x0000a 0x0000a 0xfffffff8>,
> > + <0x10000 0x10000 0xfffffff8>,
> > + <0x10001 0x10001 0xfffffff8>,
> > + <0x10002 0x10002 0xfffffff8>,
> > + <0x10003 0x10003 0xfffffff8>,
> > + <0x10008 0x10008 0xfffffff8>,
> > + <0x10009 0x10009 0xfffffff8>,
> > + <0x10010 0x10010 0xfffffff8>,
> > + <0x10011 0x10011 0xfffffff8>,
> > + <0x10012 0x10012 0xfffffff8>,
> > + <0x10013 0x10013 0xfffffff8>,
> > + <0x10019 0x10019 0xfffffff8>,
> > + <0x10021 0x10021 0xfffffff8>,
> > + <0x10030 0x10030 0xfffffff8>,
> > + <0x10031 0x10031 0xfffffff8>;
> > + riscv,raw-event-to-mhpmcounters =
> > + <0x00000000 0x00000001 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000002 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000003 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000004 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000005 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000006 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000007 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000008 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000009 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000000a 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000000b 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000000c 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000000d 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000000e 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000000f 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000010 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000011 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000012 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000013 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000014 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000015 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000016 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000017 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000018 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000019 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000001a 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000001b 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000001c 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000001d 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000001e 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000001f 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000020 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000021 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000022 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000023 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000024 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000025 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000026 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000027 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000028 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x00000029 0xffffffff 0xffffffff 0xfffffff8>,
> > + <0x00000000 0x0000002a 0xffffffff 0xffffffff 0xfffffff8>;
> > + };
> > +
> > + soc: soc {
> > + compatible = "simple-bus";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > +
> > + clint_mswi: clint-mswi@...4000000 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
> > + compatible = "sophgo,sg2042-clint-mswi", "thead,c900-clint-mswi";
> > + reg = <0x00000070 0x94000000 0x00000000 0x00004000>;
> > + interrupts-extended = <
>
> Your formatting is odd. This wrap is not needed.
>
> > + &cpu0_intc 3
> > + &cpu1_intc 3
> > + &cpu2_intc 3
> > + &cpu3_intc 3
> > + &cpu4_intc 3
> > + &cpu5_intc 3
> > + &cpu6_intc 3
> > + &cpu7_intc 3
> > + &cpu8_intc 3
> > + &cpu9_intc 3
> > + &cpu10_intc 3
> > + &cpu11_intc 3
> > + &cpu12_intc 3
> > + &cpu13_intc 3
> > + &cpu14_intc 3
> > + &cpu15_intc 3
> > + &cpu16_intc 3
> > + &cpu17_intc 3
> > + &cpu18_intc 3
> > + &cpu19_intc 3
> > + &cpu20_intc 3
> > + &cpu21_intc 3
> > + &cpu22_intc 3
> > + &cpu23_intc 3
> > + &cpu24_intc 3
> > + &cpu25_intc 3
> > + &cpu26_intc 3
> > + &cpu27_intc 3
> > + &cpu28_intc 3
> > + &cpu29_intc 3
> > + &cpu30_intc 3
> > + &cpu31_intc 3
> > + &cpu32_intc 3
> > + &cpu33_intc 3
> > + &cpu34_intc 3
> > + &cpu35_intc 3
> > + &cpu36_intc 3
> > + &cpu37_intc 3
> > + &cpu38_intc 3
> > + &cpu39_intc 3
> > + &cpu40_intc 3
> > + &cpu41_intc 3
> > + &cpu42_intc 3
> > + &cpu43_intc 3
> > + &cpu44_intc 3
> > + &cpu45_intc 3
> > + &cpu46_intc 3
> > + &cpu47_intc 3
> > + &cpu48_intc 3
> > + &cpu49_intc 3
> > + &cpu50_intc 3
> > + &cpu51_intc 3
> > + &cpu52_intc 3
> > + &cpu53_intc 3
> > + &cpu54_intc 3
> > + &cpu55_intc 3
> > + &cpu56_intc 3
> > + &cpu57_intc 3
> > + &cpu58_intc 3
> > + &cpu59_intc 3
> > + &cpu60_intc 3
> > + &cpu61_intc 3
> > + &cpu62_intc 3
> > + &cpu63_intc 3
> > + >;
> > + };
> > +
> > + clint_mtimer0: clint-mtimer@...c000000 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
> > + compatible = "sophgo,sg2042-clint-mtimer", "thead,c900-clint-mtimer";
> > + reg = <0x00000070 0xac000000 0x00000000 0x00007ff8>;
> > + interrupts-extended = <
> > + &cpu0_intc 7
> > + &cpu1_intc 7
> > + &cpu2_intc 7
> > + &cpu3_intc 7
> > + >;
> > + };
> > +
> > + clint_mtimer1: clint-mtimer@...c010000 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
> > + compatible = "sophgo,sg2042-clint-mtimer", "thead,c900-clint-mtimer";
> > + reg = <0x00000070 0xac010000 0x00000000 0x00007ff8>;
> > + interrupts-extended = <
> > + &cpu4_intc 7
>
> Srsly, fix your style. This is unreadable.
>
> > + &cpu5_intc 7
> > + &cpu6_intc 7
> > + &cpu7_intc 7
> > + >;
> > + };
> > +
>
> ...
>
> > +
> > + intc: interrupt-controller@...0000000 {
> > + compatible = "sophgo,sg2042-plic", "thead,c900-plic";
> > + #address-cells = <0>;
> > + #interrupt-cells = <2>;
> > + reg = <0x00000070 0x90000000 0x00000000 0x04000000>;
> > + interrupt-controller;
> > + interrupts-extended = <
> > + &cpu0_intc 0xffffffff &cpu0_intc 9
> > + &cpu1_intc 0xffffffff &cpu1_intc 9
> > + &cpu2_intc 0xffffffff &cpu2_intc 9
> > + &cpu3_intc 0xffffffff &cpu3_intc 9
> > + &cpu4_intc 0xffffffff &cpu4_intc 9
> > + &cpu5_intc 0xffffffff &cpu5_intc 9
> > + &cpu6_intc 0xffffffff &cpu6_intc 9
> > + &cpu7_intc 0xffffffff &cpu7_intc 9
> > + &cpu8_intc 0xffffffff &cpu8_intc 9
> > + &cpu9_intc 0xffffffff &cpu9_intc 9
> > + &cpu10_intc 0xffffffff &cpu10_intc 9
> > + &cpu11_intc 0xffffffff &cpu11_intc 9
> > + &cpu12_intc 0xffffffff &cpu12_intc 9
> > + &cpu13_intc 0xffffffff &cpu13_intc 9
> > + &cpu14_intc 0xffffffff &cpu14_intc 9
> > + &cpu15_intc 0xffffffff &cpu15_intc 9
> > + &cpu16_intc 0xffffffff &cpu16_intc 9
> > + &cpu17_intc 0xffffffff &cpu17_intc 9
> > + &cpu18_intc 0xffffffff &cpu18_intc 9
> > + &cpu19_intc 0xffffffff &cpu19_intc 9
> > + &cpu20_intc 0xffffffff &cpu20_intc 9
> > + &cpu21_intc 0xffffffff &cpu21_intc 9
> > + &cpu22_intc 0xffffffff &cpu22_intc 9
> > + &cpu23_intc 0xffffffff &cpu23_intc 9
> > + &cpu24_intc 0xffffffff &cpu24_intc 9
> > + &cpu25_intc 0xffffffff &cpu25_intc 9
> > + &cpu26_intc 0xffffffff &cpu26_intc 9
> > + &cpu27_intc 0xffffffff &cpu27_intc 9
> > + &cpu28_intc 0xffffffff &cpu28_intc 9
> > + &cpu29_intc 0xffffffff &cpu29_intc 9
> > + &cpu30_intc 0xffffffff &cpu30_intc 9
> > + &cpu31_intc 0xffffffff &cpu31_intc 9
> > + &cpu32_intc 0xffffffff &cpu32_intc 9
> > + &cpu33_intc 0xffffffff &cpu33_intc 9
> > + &cpu34_intc 0xffffffff &cpu34_intc 9
> > + &cpu35_intc 0xffffffff &cpu35_intc 9
> > + &cpu36_intc 0xffffffff &cpu36_intc 9
> > + &cpu37_intc 0xffffffff &cpu37_intc 9
> > + &cpu38_intc 0xffffffff &cpu38_intc 9
> > + &cpu39_intc 0xffffffff &cpu39_intc 9
> > + &cpu40_intc 0xffffffff &cpu40_intc 9
> > + &cpu41_intc 0xffffffff &cpu41_intc 9
> > + &cpu42_intc 0xffffffff &cpu42_intc 9
> > + &cpu43_intc 0xffffffff &cpu43_intc 9
> > + &cpu44_intc 0xffffffff &cpu44_intc 9
> > + &cpu45_intc 0xffffffff &cpu45_intc 9
> > + &cpu46_intc 0xffffffff &cpu46_intc 9
> > + &cpu47_intc 0xffffffff &cpu47_intc 9
> > + &cpu48_intc 0xffffffff &cpu48_intc 9
> > + &cpu49_intc 0xffffffff &cpu49_intc 9
> > + &cpu50_intc 0xffffffff &cpu50_intc 9
> > + &cpu51_intc 0xffffffff &cpu51_intc 9
> > + &cpu52_intc 0xffffffff &cpu52_intc 9
> > + &cpu53_intc 0xffffffff &cpu53_intc 9
> > + &cpu54_intc 0xffffffff &cpu54_intc 9
> > + &cpu55_intc 0xffffffff &cpu55_intc 9
> > + &cpu56_intc 0xffffffff &cpu56_intc 9
> > + &cpu57_intc 0xffffffff &cpu57_intc 9
> > + &cpu58_intc 0xffffffff &cpu58_intc 9
> > + &cpu59_intc 0xffffffff &cpu59_intc 9
> > + &cpu60_intc 0xffffffff &cpu60_intc 9
> > + &cpu61_intc 0xffffffff &cpu61_intc 9
> > + &cpu62_intc 0xffffffff &cpu62_intc 9
> > + &cpu63_intc 0xffffffff &cpu63_intc 9
> > + >;
> > + riscv,ndev = <224>;
> > + };
> > +
> > + uart0: serial@...0000000 {
> > + compatible = "snps,dw-apb-uart";
> > + reg = <0x00000070 0x40000000 0x00000000 0x00001000>;
> > + interrupt-parent = <&intc>;
> > + interrupts = <SOC_PERIPHERAL_IRQ(112) IRQ_TYPE_LEVEL_HIGH>;
> > + clock-frequency = <500000000>;
> > + reg-shift = <2>;
> > + reg-io-width = <4>;
> > + };
> > + };
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + };
>
> This does not go to the end. Keep the nodes ordered alphanumerically.
>
> > +
> > + chosen: chosen {
> > + bootargs = "console=ttyS0,115200 earlycon";
>
> NAK. No need and not suitable for mainline usage.
>
> > + stdout-path = "serial0";
>
> You need only this.
>
> > + };
> > +};
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists