linux-kernel - Re: [PATCH 2/2] staging: vme_user: Fix block comments where '*' on each line should be aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQboO4KSoDuANDYe@HP-ENVY-Notebook>
Date:   Sun, 17 Sep 2023 13:51:23 +0200
From:   Jonathan Bergh <bergh.jonathan@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: vme_user: Fix block comments where '*' on
 each line should be aligned

On Wed, Sep 13, 2023 at 10:33:24AM +0200, Greg KH wrote:
> On Sat, Sep 09, 2023 at 08:48:18PM +0200, Jonathan Bergh wrote:
> > Fixed checkpatch warnings where lines with '*' in block comments should
> > be aligned and were not as well as incorrect tab spacings at the start of
> > comment lines.
> > 
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@...il.com>
> > ---
> >  drivers/staging/vme_user/vme_tsi148.h | 140 +++++++++++++-------------
> >  1 file changed, 70 insertions(+), 70 deletions(-)
> > 
> > diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> > index dbdf5dabaf90..9748b7897527 100644
> > --- a/drivers/staging/vme_user/vme_tsi148.h
> > +++ b/drivers/staging/vme_user/vme_tsi148.h
> > @@ -251,28 +251,28 @@ static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1,
> >   */
> >  #define TSI148_LCSR_VMEFL	0x250
> >  
> > -	/*
> > -	 * VME exception.
> > -	 * offset  260
> > +/*
> > + * VME exception.
> > + * offset  0x260
> 
> This change is not documented :(
> 
> Also I have two 2/2 patches, yet they are both different :(
> 
> Please fix this up and send a whole new series, properly versioned,
> as-is, I have no idea what to do here.

Great, thanks for your help with these.